Keep other static class members, such as defaultProps

[athenayao]

I've been trying this out against our codebase, and I found that it was stripping out all static class members, not just propTypes.

Tracked down the issue to isPropTypesMember where getFullText returns a string surrounded by whitespace; so I've fixed that in 95f6b0e.

That makes it so that we check if propTypes === propTypes, instead of if the propTypes !== propTypes. And that makes it strip out propTypes, but keep all other static class members which is what I think we want!

Now here's the hacky part:
that caused end-to-end initial-state-and-proprypes and end-to-end initial-state-and-proprypes-and-set-state to fail because getFullText returns empty in those cases (Going into the very nitty-gritty, the IdentifierType in these cases has pos: -1, end: -1).

I'm using escapedText here as a fallback but this feels like a gigantic hack; have you run into this before, and do you know what might be the best way to fix it?

[mohsen1]

Thanks for this work. I'll help you to get this merged.

To answer your question, yes. I've seen getText throwing because node is at -1,-1. Guessing this is because node was added by other transformers to the AST without having an actual position in printed source. Copying @RyanCavanaugh and @rbuckton for comments about that.

Also copying @vincentbel to review as he helped a lot with this project as well.

[RyanCavanaugh]

Guessing this is because node was added by other transformers to the AST without having an actual position in printed source.

This is correct. You can use the function nodeIsSynthesized to determine if a node is synthesized without relying on the underlying representation of -1, -1 to indicate a synthetic node.

What you actually do when faced with a synthetic node is really dependent on the application. Reading the .escapedText is fine IMHO (maybe test using .kind instead of in) but I'd defer to @rbuckton's opinion on that.

[athenayao]

.kind looks cool; I've updated to using that entirely instead of getFullText. Since the typedef for SyntaxKind.Identifier shows that escapedText is a required attribute, this seems safe.

[athenayao]

Signed CLA!

[mohsen1]

you can use ts.IsIdentifier(classMember.name)

[athenayao]

Thanks for the tip. Updated!