Skip to content
This repository was archived by the owner on Sep 21, 2019. It is now read-only.

Avoid repeated state type members #22

Merged
merged 10 commits into from
Feb 5, 2018
Merged

Avoid repeated state type members #22

merged 10 commits into from
Feb 5, 2018

Conversation

mohsen1
Copy link
Contributor

@mohsen1 mohsen1 commented Jan 20, 2018

Fixes #13

Work in progress. Too sleepy to actually fix it...

@mohsen1
Copy link
Contributor Author

mohsen1 commented Jan 20, 2018 •
edited
Loading

This makes more sense to be done in collapseIntersectionInterfacesTransform.

It's important that we collapse {foo: string} & {foo: number} into {foo: string | number} instead of ignoring repeated members just because they have similar names.

@mohsen1
Copy link
Contributor Author

mohsen1 commented Jan 25, 2018

@vincentbel I can't find time to look into this. Feel free to pick it up from here :)

@mohsen1 mohsen1 merged commit 1e17c1b into master Feb 5, 2018
@mohsen1 mohsen1 deleted the repeated-state branch February 5, 2018 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid repeat state members
1 participant
@mohsen1