-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gzip support for JSON pages #571
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bc2774a
Server JSON pages directly from the filesystem.
arunoda b6daa28
Make Json pages even if there's an error.
arunoda 6dd5db3
Implement much better page serving.
arunoda bff2435
Use JsonPagesPlugin in the production mode as well.
arunoda 901915d
Add gzip support for JSON pages.
arunoda 6401e33
Merge master.
arunoda 3af72f1
Use glob-promise instead of recursive-readdir
arunoda 81ba173
Handle renderStatic 404 properly.
arunoda 298629f
Simply the gzip code.
arunoda b0b04a7
Cache already read JSON pages.
arunoda 1e0e7a8
Change JSON pages extension to .json.
arunoda e24f261
Fix HMR related issue.
arunoda 7a04f38
Fix hot-reload for .json solely on server.
arunoda 79d566c
Properly clear cache on hot-reloader.
arunoda 352fe77
Convert .js pages into .json page right inside the plugin.
arunoda 20d01ba
Fix gzipping .json pages.
arunoda 343cb92
Remove unwanted json pages cleanup.
arunoda 370189b
Get rid of deprecated fs.exists for fs.access
arunoda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Server JSON pages directly from the filesystem.
- Loading branch information
commit bc2774ae3bfcf51c9e297d60e34e2990d67c5df3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
export default class JsonPagesPlugin { | ||
apply (compiler) { | ||
compiler.plugin('emit', (compilation, callback) => { | ||
const pages = Object | ||
.keys(compilation.assets) | ||
.filter((filename) => /^bundles\/pages/.test(filename)) | ||
|
||
pages.forEach((pageName) => { | ||
const page = compilation.assets[pageName] | ||
const content = page.source() | ||
const newContent = JSON.stringify({ component: content }) | ||
page.source = () => newContent | ||
page.size = () => newContent.length | ||
}) | ||
|
||
callback() | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,14 +44,17 @@ async function doRender (req, res, pathname, query, { | |
|
||
const [ | ||
props, | ||
component, | ||
errorComponent | ||
componentJson, | ||
errorComponentJson | ||
] = await Promise.all([ | ||
Component.getInitialProps ? Component.getInitialProps(ctx) : {}, | ||
read(join(dir, '.next', 'bundles', 'pages', page)), | ||
read(join(dir, '.next', 'bundles', 'pages', dev ? '_error-debug' : '_error')) | ||
]) | ||
|
||
const component = JSON.parse(componentJson).component | ||
const errorComponent = JSON.parse(errorComponentJson).component | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should cache the parsed result. |
||
|
||
// the response might be finshed on the getinitialprops call | ||
if (res.finished) return | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkzawa This is my first webpack plugin.
Could you check whether I have done something ugly here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍