Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gzip support for JSON pages #571

Merged
merged 18 commits into from
Dec 31, 2016
Merged

Add Gzip support for JSON pages #571

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bc2774a
Server JSON pages directly from the filesystem.
arunoda Dec 30, 2016
b6daa28
Make Json pages even if there's an error.
arunoda Dec 30, 2016
6dd5db3
Implement much better page serving.
arunoda Dec 30, 2016
bff2435
Use JsonPagesPlugin in the production mode as well.
arunoda Dec 30, 2016
901915d
Add gzip support for JSON pages.
arunoda Dec 30, 2016
6401e33
Merge master.
arunoda Dec 30, 2016
3af72f1
Use glob-promise instead of recursive-readdir
arunoda Dec 30, 2016
81ba173
Handle renderStatic 404 properly.
arunoda Dec 30, 2016
298629f
Simply the gzip code.
arunoda Dec 30, 2016
b0b04a7
Cache already read JSON pages.
arunoda Dec 30, 2016
1e0e7a8
Change JSON pages extension to .json.
arunoda Dec 30, 2016
e24f261
Fix HMR related issue.
arunoda Dec 30, 2016
7a04f38
Fix hot-reload for .json solely on server.
arunoda Dec 31, 2016
79d566c
Properly clear cache on hot-reloader.
arunoda Dec 31, 2016
352fe77
Convert .js pages into .json page right inside the plugin.
arunoda Dec 31, 2016
20d01ba
Fix gzipping .json pages.
arunoda Dec 31, 2016
343cb92
Remove unwanted json pages cleanup.
arunoda Dec 31, 2016
370189b
Get rid of deprecated fs.exists for fs.access
arunoda Dec 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make Json pages even if there's an error.
  • Loading branch information
@arunoda
arunoda committed Dec 30, 2016
commit b6daa2879043daa389c7f34aacf95e8e3699bc49
5 changes: 4 additions & 1 deletion server/build/plugins/json-pages-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
export default class JsonPagesPlugin {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkzawa This is my first webpack plugin.
Could you check whether I have done something ugly here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

apply (compiler) {
compiler.plugin('emit', (compilation, callback) => {
compiler.plugin('after-compile', (compilation, callback) => {
const pages = Object
.keys(compilation.assets)
.filter((filename) => /^bundles\/pages/.test(filename))

pages.forEach((pageName) => {
const page = compilation.assets[pageName]
if (page.jsoned) return

const content = page.source()
const newContent = JSON.stringify({ component: content })
page.source = () => newContent
page.size = () => newContent.length
page.jsoned = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the extension to .json ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That can be done. I'll try it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

})

callback()
Expand Down
4 changes: 2 additions & 2 deletions server/build/webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ export default async function createCompiler (dir, { dev = false, quiet = false
new webpack.HotModuleReplacementPlugin(),
new webpack.NoErrorsPlugin(),
new DetachPlugin(),
new JsonPagesPlugin(),
new DynamicEntryPlugin(),
new UnlinkFilePlugin(),
new WatchRemoveEventPlugin(),
new WatchPagesPlugin(dir)
new WatchPagesPlugin(dir),
new JsonPagesPlugin()
)
if (!quiet) {
plugins.push(new FriendlyErrorsWebpackPlugin())
Expand Down