reland: Fix RelBase indexing with composite types #65550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
This was referenced May 1, 2023
Closed
bnbarham
reviewed
May 1, 2023
This reverts commit 5e2c7a9.
keith
force-pushed
the
ks/reland-fix-relbase-indexing-with-composite-types
branch
from
e395efb to
f0629bd
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS Platform |
bnbarham
approved these changes
May 2, 2023
keith
added a commit
to keith/swift
that referenced
this pull request
May 3, 2023
Previously the index data differed when using `Foo, Bar` vs `Foo & Bar`. Fixes swiftlang#56255 (cherry picked from commit 6c2ccb4)
keith
added a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
visitDeclReferencechanges from the first change. This means that nested typealiases are no longer expanded in the index as references, except in the case they are inherited from a type. This also adds a test covering the crash that snuck throughThis reverts commit 5e2c7a9.