Skip to content

Fix RelBase indexing with composite types #64997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

keith
Copy link
Member

@keith keith commented Apr 7, 2023

Previously the index data differed when using Foo, Bar vs Foo & Bar.

Fixes #56255

@keith
Copy link
Member Author

keith commented Apr 7, 2023

@swift-ci please test

@keith keith requested a review from akyrtzi April 7, 2023 02:12
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this Keith :)!

@keith keith force-pushed the ks/fix-relbase-indexing-with-composite-types branch from cb65358 to d800cfa Compare April 27, 2023 19:09
@keith keith requested a review from bnbarham April 27, 2023 20:03
@keith
Copy link
Member Author

keith commented Apr 27, 2023

@swift-ci please test

@keith
Copy link
Member Author

keith commented Apr 27, 2023

@swift-ci please test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again Keith!

@keith
Copy link
Member Author

keith commented Apr 28, 2023

@swift-ci please test

@keith keith requested a review from bnbarham April 28, 2023 20:01
@keith
Copy link
Member Author

keith commented Apr 28, 2023

@swift-ci please test Windows Platform

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@keith keith force-pushed the ks/fix-relbase-indexing-with-composite-types branch from 41bc7b3 to b90aed4 Compare April 28, 2023 21:51
@keith
Copy link
Member Author

keith commented Apr 28, 2023

@swift-ci please test

@keith keith force-pushed the ks/fix-relbase-indexing-with-composite-types branch from b90aed4 to c2c1b0a Compare April 28, 2023 22:06
@keith keith requested review from ahoppen and rintaro as code owners April 28, 2023 22:06
@keith
Copy link
Member Author

keith commented Apr 28, 2023

@swift-ci please test and merge

1 similar comment
@keith
Copy link
Member Author

keith commented Apr 29, 2023

@swift-ci please test and merge

Previously the index data differed when using `Foo, Bar` vs `Foo & Bar`.

Fixes swiftlang#56255
@keith keith force-pushed the ks/fix-relbase-indexing-with-composite-types branch from c2c1b0a to 7a5e9dc Compare April 29, 2023 19:46
@keith
Copy link
Member Author

keith commented Apr 29, 2023

@swift-ci please test and merge

@swift-ci swift-ci merged commit 404b925 into swiftlang:main Apr 30, 2023
@keith keith deleted the ks/fix-relbase-indexing-with-composite-types branch April 30, 2023 19:46
keith added a commit to keith/swift that referenced this pull request Apr 30, 2023
Previously the index data differed when using `Foo, Bar` vs `Foo & Bar`.

Fixes swiftlang#56255

(cherry picked from commit 7a5e9dc / swiftlang#64997)
@keith
Copy link
Member Author

keith commented May 1, 2023

#65550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SR-13857] indexstore missing references for superclass / protocol when using composition
4 participants