Skip to content

Use more distinct characters for 'skip' and 'pass w/known issues' symbols #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Use more distinct characters for 'skip' and 'pass w/known issues' symbols #983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Sources/Testing/Events/Recorder/Event.Symbol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ extension Event.Symbol {
("\u{10065F}", "arrow.triangle.turn.up.right.diamond.fill")
case let .pass(knownIssueCount):
if knownIssueCount > 0 {
("\u{100884}", "xmark.diamond.fill")
("\u{100883}", "xmark.diamond")
} else {
("\u{10105B}", "checkmark.diamond.fill")
}
Expand Down Expand Up @@ -118,8 +118,8 @@ extension Event.Symbol {
// Unicode: WHITE DIAMOND
return "\u{25C7}"
case .skip:
// Unicode: HEAVY BALLOT X
return "\u{2718}"
// Unicode: HEAVY ROUND-TIPPED RIGHTWARDS ARROW
return "\u{279C}"
case let .pass(knownIssueCount):
if knownIssueCount > 0 {
// Unicode: HEAVY BALLOT X
Expand Down Expand Up @@ -156,8 +156,8 @@ extension Event.Symbol {
// Unicode: LOZENGE
return "\u{25CA}"
case .skip:
// Unicode: MULTIPLICATION SIGN
return "\u{00D7}"
// Unicode: HEAVY ROUND-TIPPED RIGHTWARDS ARROW
return "\u{279C}"
case let .pass(knownIssueCount):
if knownIssueCount > 0 {
// Unicode: MULTIPLICATION SIGN
Expand Down