Use more distinct characters for 'skip' and 'pass w/known issues' symbols #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
enhancement
stmontgomery
requested review from
SeanROlszewski,
briancroom,
grynspan and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
2 tasks
Contributor
Author
|
Here's a screenshot showing these changes rendered using the new utility I added in #984: |
grynspan
approved these changes
Feb 28, 2025
stmontgomery
added a commit
that referenced
this pull request
Feb 28, 2025
This adds a development-only utility executable target to the package which allows previewing the event symbols rendered using various console output styles. <img width="815" alt="Screenshot 2025-02-28 at 2 14 47 PM" src="https://github.com/user-attachments/assets/6a1a58d3-10e0-4c51-8c1c-c3581fa0f310" /> ### Motivation: This is a tool I made and found useful while working on #983. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Feb 28, 2025
Swift-testing updated their icons for test failure in swiftlang/swift-testing#983
plemarquand
added a commit
to swiftlang/vscode-swift
that referenced
this pull request
Mar 5, 2025
Swift-testing updated their icons for test failure in swiftlang/swift-testing#983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refines the characters used for the
.failand.pass(knownIssueCount:)symbols to make them more distinct, especially when rendered in a console without ANSI colors enabled.Checklist: