Skip to content

Ensure the .whenEmbedded() build setting condition evaluates to false when building for non-Embedded without a fallback condition #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Ensure the .whenEmbedded() build setting condition evaluates to false when building for non-Embedded without a fallback condition #1081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,9 @@ extension BuildSettingCondition {
if let nonEmbeddedCondition = nonEmbeddedCondition() {
nonEmbeddedCondition
} else {
// The caller did not supply a fallback.
.when(platforms: [])
// The caller did not supply a fallback. Specify a non-existent platform
// to ensure this condition never matches.
.when(platforms: [.custom("DoesNotExist")])
}
} else {
// Enable unconditionally because the target is Embedded Swift.
Expand Down