Ensure the .whenEmbedded() build setting condition evaluates to false when building for non-Embedded without a fallback condition #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when building for non-Embedded without a fallback condition
stmontgomery
added
bug
stmontgomery
requested review from
SeanROlszewski,
briancroom,
grynspan and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
briancroom
approved these changes
Apr 17, 2025
chrismiles
approved these changes
Apr 17, 2025
Contributor
Author
|
The macOS CI failure is expected to be resolved by swiftlang/swift#80830. Proceeding to merge, given this is a known issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unintended side effect from #1043 where the
SWT_NO_LEGACY_TEST_DISCOVERYcompilation conditional was being applied when building for non-Embedded.Checklist: