[FreeBSD] support FreeBSD #861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Mar 17, 2025
| @@ -27,6 +27,8 @@ function(get_swift_host_arch result_var_name) | |||
| set("${result_var_name}" "armv7" PARENT_SCOPE) | |||
| elseif("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "armv7l") | |||
| set("${result_var_name}" "armv7" PARENT_SCOPE) | |||
| elseif("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "amd64") | |||
| set("${result_var_name}" "x86_64" PARENT_SCOPE) | |||
There was a problem hiding this comment.
Depending on land order - I think that #860 should obviate/clean up this part.
| typedef int dispatch_runloop_handle_t; | ||
| #elif defined(__FreeBSD__) | ||
| typedef uint64_t dispatch_runloop_handle_t; |
There was a problem hiding this comment.
Should this be uint64_t or uintptr_t? (i.e. is the handle pointer shaped or an integer shaped value?)
There was a problem hiding this comment.
this will be an integer shaped value. This is used to adopt the pipe based mechanism to bridge between Foundation swiftlang/swift-corelibs-foundation#3004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds FreeBSD support to libdispatch.
This patch is partly based on #561 with bug fixes and uses the pipe based mechanism based on #559 to bridge with CFRunLoop, since part of the CFRunLoop changes already landed in CoreFoundation.
In addition to above changes, also implements workqueue and limited DispatchSource support.