[FreeBSD] Enable CFRunLoop support #5188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Mar 17, 2025
| @@ -72,7 +72,7 @@ extern bool _dispatch_runloop_root_queue_perform_4CF(dispatch_queue_t queue); | |||
|
|
|||
| #if TARGET_OS_MAC | |||
| typedef mach_port_t dispatch_runloop_handle_t; | |||
| #elif defined(__linux__) || defined(__FreeBSD__) | |||
| #elif defined(__linux__) | |||
| typedef int dispatch_runloop_handle_t; | |||
There was a problem hiding this comment.
I believe that there is a type mismatch here which could truncate the value.
There was a problem hiding this comment.
Removing || defined(__FreeBSD__) here makes dispatch_runloop_handle_t type alias to 'uint64_t' (line 80), which fallback to the generic unix implementation.
Currently, although the runloop handle type is defined for FreeBSD, it is not doing anything useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables CFRunLoop for FreeBSD.
Related libdispatch PR: swiftlang/swift-corelibs-libdispatch#861