Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix autolink mechanism for static libraries on Linux" #3035

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Aug 11, 2021

Reverts #2996

The icui18n library that is linked against is not necessarily the same as the one used to build Foundation and Swift, so this is causing builds to fail.

@drexin
Copy link
Contributor Author

drexin commented Aug 11, 2021

cc: @kateinoigakukun

@drexin
Copy link
Contributor Author

drexin commented Aug 11, 2021

@swift-ci test

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit ec46464 into main Aug 11, 2021
@millenomi millenomi deleted the revert-2996-katei/merge-private-libs branch August 11, 2021 19:15
@kateinoigakukun
Copy link
Member

@drexin Could you let me know a sample failed CI job for investigation?

@drexin
Copy link
Contributor Author

drexin commented Aug 12, 2021

@kateinoigakukun https://ci.swift.org/job/oss-swift-package-centos-7/1112

/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../bin/ld.gold: error: cannot find -licui18n
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)

@drexin
Copy link
Contributor Author

drexin commented Aug 12, 2021

If we are building ICU from source, it should link against those libraries, which may have a different name (e.g. icui18nswift in case of the default Linux build). So the correct solution I think would be to determine to actual name of the library that cmake detects and use that here as well.

@kateinoigakukun
Copy link
Member

Thank you for sharing :) Oh, I forgot swift suffix variants. I'll work on this in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants