Fix autolink mechanism for static libraries on Linux #2996
Merged
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/merge-private-libs
branch
from
9ceb356 to
fc0c1c8
Compare
kateinoigakukun
changed the title
|
When you have this working could you add an integration test into the https://github.com/apple/swift-integration-tests repository to catch any future regressions? Thanks. There are some example tests in |
|
@spevans Okey, I'll add a test case in the repo. Thanks for letting me know :) |
|
cc @compnerd |
`Foundation` imports `CoreFoundation` with `@_implementationOnly` as a private dependency, and it doesn't emit `IMPORTED_MODULE` in swiftmodule. Users of Foundation can link `libCoreFoundation.so` automatically when using dynamic linking because it's already linked into `libFoundation.so`. However, this automatic linking doesn't work when static linking, so users need to link CoreFoundation and dependent libraries of CoreFoundation explicitly by adding `-lCoreFoundation -lBlocksRuntime -licui18n`. To avoid forcing users to link private dependencies explicitly, this patch changed to merge the dependencies into libFoundation.a. And also to avoid forcing to link dependent libs of CoreFoundation like `curl` or `icui18n`, add `LINK_LIBRARY` entry in Foundation.swiftmodule using `-public-autolink-library` which is introduced by swiftlang/swift#35936
kateinoigakukun
force-pushed
the
katei/merge-private-libs
branch
from
fc0c1c8 to
718159e
Compare
This was referenced Apr 29, 2021
|
Please test with following PR: @swift-ci Please test |
|
swiftlang/swift#35936 has been merged into main branch, so there is no blocker to merge this. Please proceed review again 🙏 |
|
Gentle ping :) |
MaxDesiatov
pushed a commit
to swiftlang/swift-integration-tests
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: [SR-14536] Importing FoundationNetworking with -static-stdlib is broken with missing symbols on Linux - Swift
Discussion: Autolinking behavior of @_implementationOnly with static linking - Development / Core Libraries - Swift Forums
Blocked by [Frontend] Add -public-autolink-library option by kateinoigakukun · Pull Request #35936 · apple/swiftOverview
FoundationimportsCoreFoundationwith@_implementationOnlyas a private dependency, and it doesn't emitIMPORTED_MODULEin swiftmodule.Users of Foundation can link
libCoreFoundation.soautomatically when using dynamic linking because it's already linked intolibFoundation.so.However, this automatic linking doesn't work when static linking, so users need to link CoreFoundation and dependent libraries of CoreFoundation explicitly by adding
-lCoreFoundation -lBlocksRuntime -licui18n.To avoid forcing users to link private dependencies explicitly, this patch changed to merge the dependencies into libFoundation.a. And also to avoid forcing to link dependent libs of CoreFoundation like
curloricui18n, addLINK_LIBRARYentry in Foundation.swiftmodule using-public-autolink-librarywhich is introduced by swiftlang/swift#35936