Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support and tests for URLComponents.percentEncodedQueryItems #2940

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Add support and tests for URLComponents.percentEncodedQueryItems #2940

merged 1 commit into from
Dec 13, 2020

Conversation

rauhul
Copy link
Member

@rauhul rauhul commented Dec 8, 2020

  • rdar://59439703 (URLComponents.percentEncodedQueryItems missing on linux)

part 2 of #2936

@rauhul
Add support and tests for URLComponents.percentEncodedQueryItems
a693f4d 
- rdar://59439703 (URLComponents.percentEncodedQueryItems missing on linux)
@rauhul rauhul requested a review from spevans December 8, 2020 07:16
@spevans
Copy link
Contributor

spevans commented Dec 8, 2020

@swift-ci test

spevans
spevans approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@spevans spevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this in once the next nightly is out to avoid the issue with stale build caches.

@rauhul
Copy link
Member Author

rauhul commented Dec 11, 2020

@spevans thanks for helping get this in, its much appreciated!

@spevans
Copy link
Contributor

spevans commented Dec 12, 2020

@swift-ci test and merge

1 similar comment
@spevans
Copy link
Contributor

spevans commented Dec 12, 2020

@swift-ci test and merge

@swift-ci swift-ci merged commit a1d7c17 into swiftlang:main Dec 13, 2020
@shahmishal shahmishal mentioned this pull request Dec 13, 2020
Merged
@lha lha mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spevans spevans spevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rauhul @spevans @swift-ci