Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreFoundation changes to enable URLComponents.percentEncodedQueryItems #2936

Conversation

rauhul
Copy link
Member

@rauhul rauhul commented Dec 6, 2020

CoreFoundation changes to enable URLComponents.percentEncodedQueryItems

Fixes from @millenomi

  • Constant strings must be correctly memory-managed in SCF.
  • Do not associate API availability to CFURLComponents calls when compiling SCF on Darwin

Fixes from @millenomi
- Constant strings must be correctly memory-managed in SCF.
- Do not associate API availability to CFURLComponents calls when compiling SCF on Darwin
@spevans
Copy link
Contributor

spevans commented Dec 6, 2020

@swift-ci test and merge

2 similar comments
@spevans
Copy link
Contributor

spevans commented Dec 6, 2020

@swift-ci test and merge

@spevans
Copy link
Contributor

spevans commented Dec 6, 2020

@swift-ci test and merge

@swift-ci swift-ci merged commit 15214a4 into swiftlang:main Dec 6, 2020
@rauhul rauhul deleted the feature/URLComponents.percentEncodedQueryItems-CF-changes branch December 8, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants