Skip to content

[lldb] Improve logging for nonexistent AST paths #7495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable/20221013
Choose a base branch
from
Open

[lldb] Improve logging for nonexistent AST paths #7495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#include "lldb/Core/Section.h"
#include "lldb/Host/FileSystem.h"
#include "lldb/Utility/DataBufferLLVM.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
#include "lldb/Utility/RangeMap.h"
#include "lldb/Utility/RegularExpression.h"
#include "lldb/Utility/Timer.h"
Expand Down Expand Up @@ -1565,10 +1567,12 @@ SymbolFileDWARFDebugMap::GetASTData(lldb::LanguageType language) {
__FUNCTION__, file_spec.GetPath().c_str());
}
} else {
if (log)
log->Printf("SymbolFileDWARFDebugMap::%s() - found reference to AST "
"file %s, but could not find the file, ignoring",
__FUNCTION__, file_spec.GetPath().c_str());
for (Log *current_log : {log, GetLog(LLDBLog::Types)})
if (current_log)
current_log->Printf("SymbolFileDWARFDebugMap::%s() - ignoring "
"nonexistent AST file %s - referenced from %s",
__FUNCTION__, file_spec.GetPath().c_str(),
m_objfile_sp->GetFileSpec().GetPath().c_str());
Copy link

@adrian-prantl adrian-prantl Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a good opportunity to convert this to LLDB_LOG (no F) and get rid of the c_str() conversions...

}

// Regardless of whether we could find the specified file, start the next
Expand Down