[lldb] Improve logging for nonexistent AST paths #7495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
requested review from
JDevlieghere,
adrian-prantl and
augusto2112
augusto2112
approved these changes
Sep 20, 2023
| current_log->Printf("SymbolFileDWARFDebugMap::%s() - ignoring " | ||
| "nonexistent AST file %s - referenced from %s", | ||
| __FUNCTION__, file_spec.GetPath().c_str(), | ||
| m_objfile_sp->GetFileSpec().GetPath().c_str()); |
There was a problem hiding this comment.
might be a good opportunity to convert this to LLDB_LOG (no F) and get rid of the c_str() conversions...
|
I would rebase this on 20230725, it won't hurt on the 20221013 branch, but it's also kind of pointless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a binary references a nonexistent .swiftmodule path, the logging to identify this issue has gone to the
dwarfchannel only. This patch makes the log also go to thelldbchannel. When there are issues with Swift expression evaluation, it's common to look at thelldb typeslog. Nonexistent .swiftmodule paths are important to surface in the types log, because without those, expressions that involve API from the missing .swiftmodule will fail.Additionally, this log message was reworded and adds the path of the binary that contains the nonexistent .swiftmodule path.