Add some documentation on the CAS Schema in MCCASObjectV1.h #5430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastogishubham
force-pushed
the
Documentation
branch
from
e3fdcf8 to
76c9fa7
Compare
rastogishubham
force-pushed
the
Documentation
branch
from
76c9fa7 to
5ff29ce
Compare
rastogishubham
force-pushed
the
Documentation
branch
from
5ff29ce to
2a49195
Compare
|
This patch doesn't have a ref from the debug info cu to the debug string cas blocks because that patch isn't merged yet, the idea would be to update this diagram when we change something |
There was a problem hiding this comment.
Is this true? Isn't that data stored in the distinctdataref?
There was a problem hiding this comment.
No, we had an experimental patch where we moved the dw_form_addrs into the distinctdataref, but since I could not address some of the comments that were left in that patch, it has not been merged yet.
# This is the 1st commit message: Add some documentation that describes the CAS schema # This is the commit message swiftlang#2: Addressed review comments # This is the commit message swiftlang#3: Addressed some more feedback
rastogishubham
force-pushed
the
Documentation
branch
from
551ca25 to
b43c9d1
Compare
This was referenced Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CAS schema for the debug info sections is getting complicated, to make sure we are aware of how the different sections are laid out, we want to document the information in the header file so it can be updated whenever a change it made