Move DW_FORM_addr to the DebugInfoDistinctDataRef and do not zero out and copy addends for debug info section #5343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastogishubham
force-pushed
the
FormAddrMove
branch
from
f53dd4d to
5e011cf
Compare
rastogishubham
force-pushed
the
FormAddrMove
branch
2 times, most recently
from
937fd50 to
3083971
Compare
rastogishubham
changed the title
|
@swift-ci please test |
…to the fixupsref instead
rastogishubham
force-pushed
the
FormAddrMove
branch
from
3083971 to
9bf9dc1
Compare
|
@swift-ci please test |
| // unresolved, this is done to improve deduplication with MCCAS. The fixup | ||
| // will be applied later when the object file is being written out. | ||
| if (!IsResolved) { | ||
| if (!IsResolved && Fragment->getParent()->getName() != "__debug_info") { |
There was a problem hiding this comment.
Since this is non-MachO-specific code, we need to do something more generic than check fort the Mach-O section name here.
There was a problem hiding this comment.
I thought the CAS was only supported for MachO, we do not want to zero out the addends for a MachO debug info section right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocation Addends are stored as DW_FORM_addr in a compile unit, we pay a cost when storing relocation addends in the form of storing the offset and the size of the addend as well. We can reduce the cost of these addends by simply storing all DW_FORM_addr's in the DebugInfoDistinctDataRef instead of storing the addends.