Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update puppeteer and add logs #4938

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

tanhauhau
Copy link
Member

trying to learn why

  1) custom-elements
       "before all" hook for "custom-method":
     Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/svelte/svelte/test/test.js)
  

  2) custom-elements
       "after all" hook for "props":
     TypeError: Cannot read property 'close' of undefined
      at Context.after (test/custom-elements/index.js:53:17)

Example

the logs itself didn't explain much. and the error usually gone after a retry on CI.

this PR is a "throw at the wall and see what sticks" attempt on investigating what's wrong.

  • Added a log right after every statement for before in custom-elements test suite
  • Upgraded puppeteer, and hopefully it's better. 🙈

@@ -44,13 +46,16 @@ describe('custom-elements', function() {

before(async () => {
svelte = loadSvelte();
console.log('[custom-element] Loaded Svelte');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also consider console.info or console.debug

@Conduitry Conduitry merged commit 16a6cc1 into sveltejs:master Jun 10, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants