Skip to content

Commit 16a6cc1

Browse files
authored
update puppeteer and add logs (#4938)
1 parent 7dfd9e9 commit 16a6cc1

File tree

3 files changed

+62
-41
lines changed

3 files changed

+62
-41
lines changed

package-lock.json

+53-37
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
"magic-string": "^0.25.3",
8686
"mocha": "^6.2.0",
8787
"periscopic": "^2.0.1",
88-
"puppeteer": "^1.19.0",
88+
"puppeteer": "^2.1.1",
8989
"rollup": "^1.27.14",
9090
"source-map": "^0.7.3",
9191
"source-map-support": "^0.5.13",

test/custom-elements/index.js

+8-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('custom-elements', function() {
2525
let code;
2626

2727
function create_server() {
28-
return new Promise((fulfil) => {
28+
return new Promise((fulfil, reject) => {
2929
const server = http.createServer((req, res) => {
3030
if (req.url === '/') {
3131
res.end(page);
@@ -36,6 +36,8 @@ describe('custom-elements', function() {
3636
}
3737
});
3838

39+
server.on('error', reject);
40+
3941
server.listen('6789', () => {
4042
fulfil(server);
4143
});
@@ -44,13 +46,16 @@ describe('custom-elements', function() {
4446

4547
before(async () => {
4648
svelte = loadSvelte();
49+
console.log('[custom-element] Loaded Svelte');
4750
server = await create_server();
51+
console.log('[custom-element] Started server');
4852
browser = await puppeteer.launch();
53+
console.log('[custom-element] Launched puppeteer browser');
4954
});
5055

5156
after(async () => {
52-
server.close();
53-
await browser.close();
57+
if (server) server.close();
58+
if (browser) await browser.close();
5459
});
5560

5661
fs.readdirSync(`${__dirname}/samples`).forEach(dir => {

0 commit comments

Comments
 (0)