Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only overwrite this in event handlers for custom events #1392

Merged
merged 1 commit into from
May 1, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #1390

@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #1392 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
+ Coverage   91.25%   91.25%   +<.01%     
==========================================
  Files         122      122              
  Lines        4484     4485       +1     
  Branches     1384     1385       +1     
==========================================
+ Hits         4092     4093       +1     
  Misses        154      154              
  Partials      238      238
Impacted Files Coverage Δ
src/compile/nodes/EventHandler.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cdffa...49a09ef. Read the comment docs.

@Conduitry
Copy link
Member

Oh, did I misunderstand you and think that you wanted to also hoist in more cases? Or, like me, did you just try hoisting, saw it broke stuff, and kick that one until later?

@Rich-Harris
Copy link
Member Author

I think we should probably hoist in more cases (by default, except for custom events), but I reckon that's a 'when we get round to it' type thing. Leaving this as-is is always the correct thing to do for regular DOM events, regardless of hoisting, so I just made the minimal change that would fix the bug

@Rich-Harris Rich-Harris merged commit 5f471e5 into master May 1, 2018
@Rich-Harris Rich-Harris deleted the gh-1390 branch May 1, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this overwritten as component name in arguments of hoisted event handler
3 participants