-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this
overwritten as component name in arguments of hoisted event handler
#1390
Comments
@Rich-Harris Sooo ... what does this mean for what we want to do here? Are you suggesting that we always want to hoist event handlers (unless it's a custom element)? |
I think we should prefer hoisting, yeah. I think we probably only want to overwrite |
@Conduitry thanks for this issue, looks like my gitter doesn't work. |
@stalkerg mine too, I think it's broken 😱 |
only overwrite this in event handlers for custom events
fixed in 2.4.1 |
See 2.1.1 vs 2.2.0.
This might be as simple as wrapping this in a check for
!this.shouldHoist
, but not sure whether that's the best solution. Maybe we should instead make surethis.shouldHoist
is false ifthis
is one of the arguments to the handler?cc @stalkerg
The text was updated successfully, but these errors were encountered: