-
-
Notifications
You must be signed in to change notification settings - Fork 822
add C implementation to @stdlib/math/base/special/ldexp
#652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am not much confident about the implementation of |
@Pranavchiku You need to refactor the |
I was thinking to wrap the |
Co-authored-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Pass both separately. No need to pass as a separate array. We only pass arrays for base functions operating on numbers when we have multiple output arguments. |
Co-authored-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
I guess, we returned to original place !
It shows me lots of conflicts in different files, hence I chose to merge the existing |
lib/node_modules/@stdlib/math/base/special/ldexp/examples/c/example.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples still need to be updated, but I can do this on my end.
Resolves #638
Checklist
@kgryte