Skip to content

add C implementation for @stdlib/math/base/special/frexp #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Dec 6, 2022
Merged

add C implementation for @stdlib/math/base/special/frexp #651

merged 29 commits into from
Dec 6, 2022

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Dec 4, 2022 •
edited
Loading

Resolves #637

Checklist

  • update readme.md
  • include.gypi
  • binding.gyp
  • include/stdlib/math/base/special/
  • manifest.json
  • src
  • lib
  • examples
  • benchmark
  • test

@kgryte

@Pranavchiku Pranavchiku mentioned this pull request Dec 4, 2022
Closed
10 tasks
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Dec 4, 2022
@Pranavchiku
Copy link
Member Author

Pranavchiku commented Dec 4, 2022 •
edited
Loading

@kgryte could you please check and confirm if the implementation in main.c is correct? I am not confident about that.

@Pranavchiku
Copy link
Member Author

Benchmarks for C are already existing, but they are different, should I add new benchmarks?

@kgryte
Copy link
Member

kgryte commented Dec 4, 2022

Add additional C benchmarks in benchmark/c/native/*. The ones at the root benchmark/c folder are for measuring libc perf.

@Pranavchiku
Copy link
Member Author

Some tests are failing (1028/6037), I guess it is because of some minor error in main.c. I am looking at it.

@Pranavchiku
Copy link
Member Author

I am not sure why those tests are failing, @kgryte if you could review the PR.

@kgryte
Copy link
Member

kgryte commented Dec 4, 2022

Trying pulling down the latest to see if tests now pass.

@Pranavchiku Pranavchiku marked this pull request as ready for review December 4, 2022 05:59
@Pranavchiku
Copy link
Member Author

All tests and benchmarks passed. This PR is ready for review :)

@Pranavchiku Pranavchiku changed the title add C implementation for @stdlib/math/base/special/frexp add C implementation for @stdlib/math/base/special/frexp Dec 5, 2022
kgryte
kgryte requested changes Dec 6, 2022
View reviewed changes
@kgryte kgryte merged commit 63e1ed8 into stdlib-js:develop Dec 6, 2022
@kgryte kgryte mentioned this pull request Dec 9, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/special/frexp
2 participants
@Pranavchiku @kgryte