Skip to content

[RFC]: refactor blas/ext/base/scusum to follow current project conventions #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 3 comments · Fixed by #1864
Closed
3 tasks done

[RFC]: refactor blas/ext/base/scusum to follow current project conventions #1516

Planeshifter opened this issue Mar 3, 2024 · 3 comments · Fixed by #1864
Assignees
@AuenKr
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/scusum to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@kunal-511
Copy link

@Planeshifter Please assign this issue. I would like to contribute

@kgryte
Copy link
Member

kgryte commented Mar 6, 2024

@kunal-511 Let's get #1727 over the finish line before moving on to additional PRs.

@AuenKr
Copy link
Contributor

AuenKr commented Mar 13, 2024 •
edited
Loading

Can I work on this issue @kgryte ??

This was referenced Mar 13, 2024
Closed
Merged
@kgryte kgryte added Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Mar 14, 2024
kgryte added a commit that referenced this issue Mar 21, 2024
@AuenKr @kgryte
refactor: update blas/ext/base/scusum to follow current project con…
5ca58c5 
…ventions

PR-URL: 	#1864
Closes: #1516
Ref: #1152
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AuenKr AuenKr

Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
4 participants
@Planeshifter @kgryte @AuenKr @kunal-511