Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report switch statement fall-through as an error #18

Merged
merged 1 commit into from
Oct 7, 2015
+1 −0
Merged

Report switch statement fall-through as an error #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions configs/inspection/Square.xml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<inspections version="1.0" is_locked="false">
<option name="myName" value="Square" />
<inspection_tool class="FallthruInSwitchStatement" enabled="true" level="ERROR" enabled_by_default="true" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/nit should we keep these alphabetized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point, I'll do that. Do you know if GitHub will correctly handle me amending and force-pushing this commit?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

been a while since I've used github, I'll defer to Jake but I think it's fine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will

On Wed, Oct 7, 2015 at 3:06 PM Davis Gallinghouse notifications@github.com
wrote:

In configs/inspection/Square.xml
#18 (comment):

@@ -2,5 +2,6 @@

-

Yeah, good point, I'll do that. Do you know if GitHub will correctly
handle me amending and force-pushing this commit?

—
Reply to this email directly or view it on GitHub
https://github.com/square/java-code-styles/pull/18/files#r41432059.

<inspection_tool class="UnnecessarySemicolon" enabled="true" level="ERROR" enabled_by_default="true" />
</inspections>