Report switch statement fall-through as an error #18
Conversation
| @@ -2,5 +2,6 @@ | |||
| <inspections version="1.0" is_locked="false"> | |||
| <option name="myName" value="Square" /> | |||
| <inspection_tool class="UnnecessarySemicolon" enabled="true" level="ERROR" enabled_by_default="true" /> | |||
| <inspection_tool class="FallthruInSwitchStatement" enabled="true" level="ERROR" enabled_by_default="true" /> | |||
There was a problem hiding this comment.
/nit should we keep these alphabetized?
There was a problem hiding this comment.
Yeah, good point, I'll do that. Do you know if GitHub will correctly handle me amending and force-pushing this commit?
There was a problem hiding this comment.
been a while since I've used github, I'll defer to Jake but I think it's fine
There was a problem hiding this comment.
It will
On Wed, Oct 7, 2015 at 3:06 PM Davis Gallinghouse notifications@github.com
wrote:
In configs/inspection/Square.xml
#18 (comment):@@ -2,5 +2,6 @@
-
Yeah, good point, I'll do that. Do you know if GitHub will correctly
handle me amending and force-pushing this commit?—
Reply to this email directly or view it on GitHub
https://github.com/square/java-code-styles/pull/18/files#r41432059.
|
I assume this can be suppressed? Fall-through can be very useful. |
|
The documentation says
|
|
Excellent! On Wed, Oct 7, 2015 at 3:08 PM Davis Gallinghouse notifications@github.com
|
Report switch statement fall-through as an error
|
Thx Davis! |
No description provided.