Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint for logging.structured.json.customizer property #43201

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Nov 15, 2024

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 15, 2024
@philwebb
Copy link
Member

I wonder why I didn't make customizer a Class in StructuredLoggingJsonProperties

@nosan
Copy link
Contributor Author

nosan commented Nov 16, 2024

I wonder why I didn't make customizer a Class in StructuredLoggingJsonProperties

Do you mean in this context? If so, I was also confused about why java.lang.Class wasn't simply used here.

    {
      "name": "logging.structured.json.customizer",
      "type": "java.lang.String",
      "description": "The fully qualified class name of a StructureLoggingJsonMembersCustomizer"
    },

@philwebb
Copy link
Member

Exactly, I've made that change in #43202 which should remove the need for additional metadata. Thanks for finding it!

@philwebb philwebb closed this Nov 16, 2024
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 16, 2024
@nosan nosan deleted the hint-logging.structured.json.customizer branch November 16, 2024 01:12
@nosan
Copy link
Contributor Author

nosan commented Jan 17, 2025

additional-spring-configuration-metadata.json in spring-boot/spring-boot-project/spring-boot/src/main/resources/META-INF still contains the following:

    {
      "name": "logging.structured.json.customizer",
      "type": "java.lang.String",
      "description": "The fully qualified class name of a StructuredLoggingJsonMembersCustomizer"
    }

Should it be updated?

    {
      "name": "logging.structured.json.customizer",
      "type": "java.lang.Class",
      "description": "The fully qualified class name of a StructuredLoggingJsonMembersCustomizer"
    }

@philwebb
Copy link
Member

Thanks @nosan, I've opened #43916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants