#35 Test create and publish a release with automatic semantic versioning #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 31, 2023 13:02
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Zero3141
changed the title
Weltraumschaf
requested changes
Aug 1, 2023
.github/workflows/release.yml
Outdated
|
|
||
| - name: Get current version | ||
| id: version | ||
| run: echo "::set-output name=version::$(./gradlew -q -Prelease.quiet currentVersion)" |
There was a problem hiding this comment.
Added a comment before this step to explain its purpose & functionality. Is this sufficient?
There was a problem hiding this comment.
That's a good starting point for the reason, but there should also be some info about the concrete syntax (::set-output name=version::). If you have a link which describes this, a link with a hint that it describes the syntax is sufficient.
added 2 commits
August 1, 2023 16:24
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
added 3 commits
August 1, 2023 16:40
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Weltraumschaf
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #35