-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate publishing of DefectDojo Java Client release to maven central #35
Comments
Mhh? It's automated: https://github.com/secureCodeBox/defectdojo-client-java/blob/main/.github/workflows/publish.yml |
Build is automated, but there is no such release in Maven Central. |
@Weltraumschaf should publish to maven central when the release doesn't contain snapshot |
Long time ago (~4 years) @rseedorff requested access to Maven Central. They said we should release some SNAPSHOT versions before they grant us access to the public repo. Now we should hook up this process. |
Found the Sonatype OSSRH issue: Looks like everything is prepared to perform a release. @rseedorff do you have the GPG key to sign the jars? Do you have your Jira Account working and can login here? |
We also need to meet some requirements:
Documentation how to do this with Gradle. |
I've raised an comment in the OSSRH issue and asked how to add more maintainers. |
@J12934 and me now have publish rights to our Sonatype staging repo. Now we can test a first release. |
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Publishing requires that all files need to be signed with GPG/PGP. For that, we need the signing key together with its password in a ci run. We store these two Github's Encrypted secrets. Signing key extraction (local)First, we need to identify the LONG_ID of the private key:
Then, we extract the private key:
It should look like the following:
Github release workflowThe release workflow runs |
Real name: the secureCodeBox authors
|
Here we can see our published snapshots. |
GPG Signing: We had the plan to use a sub key derived from a secret master key to sign the artifacts, bit it seems that Maven can't deal with sub keys. So we decided to use one dedicated GPG key only for our Java artifacts we deploy to Maven Central. |
Its recommended to set an expiration date of less than two years for our signing key. How do we keep track of this interval? @Weltraumschaf |
We add an appointment to the team calendar :-) |
We should really document all this stuff. I added your GPG notes as first part for a whole release documentation. |
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
How toconfigure it you can see in my dotfiles: https://github.com/Weltraumschaf/dotfiles/blob/master/src/dotfiles/_gitconfig#L11 Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
It is a big hassle to get Gradle releases work in GH actions as we like. After spending some time fiddling around with Gradle, we decidedto use god oldMaven, we have more knowledge in. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
How toconfigure it you can see in my dotfiles: https://github.com/Weltraumschaf/dotfiles/blob/master/src/dotfiles/_gitconfig#L11 Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
It is a big hassle to get Gradle releases work in GH actions as we like. After spending some time fiddling around with Gradle, we decidedto use god oldMaven, we have more knowledge in. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
We decided to change from Gradle to Maven bc full automatic release is not feasible int the we want it. We tried now for merely a week to get it work. With Maven it seems way more easier. |
How toconfigure it you can see in my dotfiles: https://github.com/Weltraumschaf/dotfiles/blob/master/src/dotfiles/_gitconfig#L11 Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
It is a big hassle to get Gradle releases work in GH actions as we like. After spending some time fiddling around with Gradle, we decidedto use god oldMaven, we have more knowledge in. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Problem: We enforce two status checks (DCO & Java Tests) to pass before merging. We already allowed the SCB Bot (who performs the push commit in which the version is bumped in the pom.xml) to push on the It seems like that this issue is a general issue, see this discussion. |
We have weakened the branch protection rules to decouple the release process from Issue 157. |
@Zero3141 Can we add to the action that it updates the version in the README.md?
|
The text was updated successfully, but these errors were encountered: