Add initial support for phpcs and php lint #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new linters:
* PHP Lint via the 'php -l' command to check for valid php syntax
and confirm that the file will compile
* PHP Code Sniffer via 'phpcs' to check for style problems
This can later be followed by other php tooling, but these are the
most common and are a good starting point.
|
Thanks for the contribution, @craig-davis! |
|
@sds Thank you! We use Overcommit at my employer Help Scout in many of our projects and it's been a valuable tool. I hope this contribution will be the start of adding some other PHP tools by the community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #292 to add PHP commit hooks - a much belated contribution!
This PR adds two new linters:
php -lcommand to check for valid php syntax and confirms that the file will compilephpcsto check for style problemsThis can later be followed by other php tooling, but these are the most common and I believe are a good starting point.
This may not be entirely idiomatic Ruby, please feel free to critique and suggest improvements. I've added a collection of specs that should cover the most common cases.