Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible contribution of PHP tools #292

Closed
craig-davis opened this issue Nov 7, 2015 · 2 comments
Closed

Possible contribution of PHP tools #292

craig-davis opened this issue Nov 7, 2015 · 2 comments
Labels
question

Comments

@craig-davis
Copy link
Contributor

I have initial support for PHP linting via php -l and PHP code style checks via phpcs. In the future, I plan to implement other tools from the PHP QA Toolchain.

Would you like a pull request for these initial hooks?
@lencioni
Copy link
Collaborator

lencioni commented Nov 7, 2015

Yes, absolutely we would. Please be sure to include specs and thanks for offering to help out!

@lencioni lencioni closed this as completed Nov 7, 2015
@craig-davis
Copy link
Contributor Author

Hi @lencioni - Where do you prefer that fixture files be located? I was expecting spec/overcommit/fixtures but don't see anything there.

@craig-davis craig-davis mentioned this issue Aug 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lencioni @craig-davis