Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UWP reparse point check #138928

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Fix UWP reparse point check #138928

merged 1 commit into from
Apr 1, 2025

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Mar 25, 2025

Fixes #138921

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 25, 2025
@tgross35
Copy link
Contributor

tgross35 commented Apr 1, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 1, 2025

📌 Commit 8524a7c has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 1, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 1, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2025
Rollup of 12 pull requests

Successful merges:

 - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute)
 - rust-lang#137738 (Make slice iterator constructors unstably const)
 - rust-lang#138492 (remove `feature(inline_const_pat)`)
 - rust-lang#138928 (Fix UWP reparse point check)
 - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names)
 - rust-lang#139002 (Add release notes for 1.86.0)
 - rust-lang#139022 (increment depth of nested obligations)
 - rust-lang#139060 (replace commit placeholder in vendor status with actual commit)
 - rust-lang#139102 (coverage: Avoid splitting spans during span extraction/refinement)
 - rust-lang#139129 (Add tests for slice bounds check optimization)
 - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…)
 - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Apr 1, 2025

⌛ Testing commit 8524a7c with merge e2014e8...

@bors
Copy link
Collaborator

bors commented Apr 1, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing e2014e8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 1, 2025
@bors bors merged commit e2014e8 into rust-lang:master Apr 1, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 1, 2025
Copy link

github-actions bot commented Apr 1, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0b4a81a (parent) -> e2014e8 (this PR)

Test differences

No test diffs found

Job duration changes

  1. dist-apple-various: 8233.8s -> 9164.3s (11.3%)
  2. x86_64-mingw-2: 6987.9s -> 7729.8s (10.6%)
  3. dist-x86_64-apple: 9484.6s -> 10444.4s (10.1%)
  4. dist-x86_64-msvc-alt: 7576.0s -> 8006.7s (5.7%)
  5. dist-aarch64-apple: 5582.0s -> 5861.8s (5.0%)
  6. dist-x86_64-musl: 7378.4s -> 7699.6s (4.4%)
  7. x86_64-msvc-1: 8752.0s -> 9129.4s (4.3%)
  8. dist-various-2: 3231.4s -> 3368.5s (4.2%)
  9. dist-aarch64-msvc: 8541.6s -> 8849.0s (3.6%)
  10. dist-loongarch64-musl: 5307.2s -> 5482.6s (3.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@ChrisDenton ChrisDenton deleted the fix-uwp branch April 1, 2025 22:53
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e2014e8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.2%, secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [2.6%, 4.7%] 6
Regressions ❌
(secondary)
2.4% [0.8%, 3.9%] 40
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.2% [2.6%, 4.7%] 6

Cycles

Results (primary -3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.2% [-3.2%, -3.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.2% [-3.2%, -3.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.376s -> 774.756s (0.05%)
Artifact size: 365.93 MiB -> 365.95 MiB (0.01%)

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Version: 4.2.2
Digest: sha256:ccb2698953eaebd21c7bf6268a94f9c26518a7e38e27e0b83c1fe1ad049819b1
Source commit SHA: 11bd71901bbe5b1630ceea73d27597364c9af683
##[endgroup]
Complete job name: DockerHub mirror
##[group]Run actions/checkout@v4
with:
  persist-credentials: false
  repository: rust-lang/rust
  token: ***
---
http.https://github.com/.extraheader
[command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
##[endgroup]
##[group]Run echo "***" | docker login ghcr.io -u rust-lang --password-stdin
echo "***" | docker login ghcr.io -u rust-lang --password-stdin
shell: /usr/bin/bash -e {0}
##[endgroup]
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
Post job cleanup.

github-actions bot pushed a commit to carolynzech/rust that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build std error for target *-uwp-windows-msvc
6 participants