Rollup of 7 pull requests #138830
Merged
Rollup of 7 pull requests #138830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than requiring the user to pass in a correctly sized blocks map.
It was missed in rust-lang#137165.
Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
Implement `make_mir_visitor` macro to generate `MirVisitor` and `MutMirVisitor`. Add `ret_local_mut()`, `arg_locals_mut()` and `inner_locals_mut()` to `Body`, specifically for `MutMirVisitor`.
Done automatically with VSCode.
This fixes all 3 of these tests. Done automatically in VSCode.
…rrors Couple mir building cleanups
Forward `stream_position` in `Arc<File>` as well It was missed in rust-lang#137165.
…arse-cleanup, r=notriddle Cleanup `LangString::parse` Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
stable_mir: Add `MutMirVisitor` Resolves: [rust-lang/project-stable-mir#81](rust-lang/project-stable-mir#81). I am unsure if we should add a `MutableBody` like Kani did. Currently, I use `&mut Body` in `MutMirVisitor::visit_body()`. r? ``````@celinval``````
Fix build failure on Trusty
This target is currently broken due to update to 2024 editon.
```console
$ cargo new --lib repro
$ cd repro
$ cargo check -Z build-std=std --target aarch64-unknown-trusty
Compiling std v0.0.0 ($HOME/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/std)
error: extern blocks must be unsafe
--> $HOME/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/sys/random/trusty.rs:1:1
|
1 | / extern "C" {
2 | | fn trusty_rng_secure_rand(randomBuffer: *mut core::ffi::c_void, randomBufferLen: libc::size_t);
3 | | }
| |_^
error: could not compile `std` (lib) due to 1 previous error
```
cc ```@randomPoison``` ```@ahomescu``` ([target maintainers](https://doc.rust-lang.org/nightly/rustc/platform-support/trusty.html#target-maintainers))
…e1-dead Make `crate_hash` not iterate over `hir_crate` owners anymore cc rust-lang#95004 One more direct usage of hir::Crate removed
…uillaumeGomez jsondocck: Replace `jsonpath_lib` with `jsonpath-rust` The current jsonpath implementation we use isn't spec-compliant, and is buggy. See freestrings/jsonpath#91 To solve it, it's replaced with https://github.com/besok/jsonpath-rust. This is spec-compiant, and doesn't have a really awkward bug we need to always dance around. Unfortunately, this requires rewriting almost every test, as the behaviour of `[?(```@`,``` which is *extremely* common was changed. (But the new behaviour makes way more sense, and isn't buggy with tripply nested selectors) Unblocks rust-lang#110406. Makes rust-lang#100515 much easier as we don't need to explain the broken JSONPath implementation Best reviewed commit-by-commit. The first does the replacement. The next two rewrite the test-suite mechanically. The last rewrites the test-suite by hand. r? ```@GuillaumeGomez```
rustbot
added
A-rustdoc-json
|
@bors r+ rollup=never p=5 |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit a4c0173 with merge d93f678fa55842cccd2f091deccd93e9494b3764... |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 0ce1369 (parent) -> d93f678 (this PR) Test differencesShow 200 test diffsAdditionally, 200 doctest diffs were found. These are ignored, as they are noisy. Job group index |
|
📌 Perf builds for each rolled up PR:
previous master: 0ce1369bde In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
stream_positioninArc<File>as well #138490 (Forwardstream_positioninArc<File>as well)LangString::parse#138535 (CleanupLangString::parse)MutMirVisitor#138536 (stable_mir: AddMutMirVisitor)crate_hashnot iterate overhir_crateowners anymore #138750 (Makecrate_hashnot iterate overhir_crateowners anymore)jsonpath_libwithjsonpath-rust#138763 (jsondocck: Replacejsonpath_libwithjsonpath-rust)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup