Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit_extern_abis Feature and Enforce Explicit ABIs #135340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add explicit_extern_abis Feature and Enforce Explicit ABIs #135340

wants to merge 2 commits into from
+200 −5

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Jan 10, 2025 •
edited
Loading

The unstable explicit_extern_abis feature is introduced, requiring explicit ABIs in extern blocks. Hard errors will be enforced with this feature enabled in a future edition.

RFC rust-lang/rfcs#3722

Update #134986

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@traviscross traviscross added the F-explicit_extern_abis `#![feature(explicit_extern_abis)]` label Jan 10, 2025
@traviscross
Copy link
Contributor

@rustbot labels +S-blocked
@rustbot author

We're still finalizing the timing and name of the next edition, and in any case, I think I'd like to see a separate PR for adding the various bits for the next edition that's separate from any edition item.

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2025
@traviscross traviscross mentioned this pull request Jan 10, 2025
Open
8 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@obeis obeis force-pushed the explicit-extern-abis branch from 938c721 to b327d2d Compare January 10, 2025 18:14
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

I do not think we will accept the edition changes being folded into this PR, @obeis

@obeis obeis force-pushed the explicit-extern-abis branch from b327d2d to e25d0af Compare January 10, 2025 19:42
@obeis obeis force-pushed the explicit-extern-abis branch from e25d0af to 20f28b1 Compare January 10, 2025 19:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@obeis obeis force-pushed the explicit-extern-abis branch 2 times, most recently from fe8b62b to bc8ed0e Compare January 10, 2025 20:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@obeis obeis force-pushed the explicit-extern-abis branch from bc8ed0e to e1db710 Compare January 11, 2025 15:05
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jan 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@traviscross traviscross added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2025
@Amanieu Amanieu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jan 22, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025
@obeis obeis force-pushed the explicit-extern-abis branch 3 times, most recently from df735f8 to 15be183 Compare March 8, 2025 21:42
@obeis obeis force-pushed the explicit-extern-abis branch 2 times, most recently from e3867bd to 42277b4 Compare March 9, 2025 15:51
@obeis
Copy link
Contributor Author

obeis commented Mar 9, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2025
@obeis
Add explicit_extern_abis unstable feature
8ed9b1b 
also add `explicit-extern-abis` feature section to
the unstable book.
@obeis obeis force-pushed the explicit-extern-abis branch from 42277b4 to 90a1e49 Compare March 14, 2025 12:15
@obeis obeis requested a review from traviscross March 15, 2025 02:03
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2025
@obeis obeis force-pushed the explicit-extern-abis branch from 90a1e49 to d8ddeb1 Compare March 15, 2025 13:31
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 15, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2025
@obeis obeis force-pushed the explicit-extern-abis branch from d8ddeb1 to 008c19c Compare March 18, 2025 19:48
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2025
@obeis obeis requested a review from traviscross March 18, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@ytmimi ytmimi ytmimi left review comments

@traviscross traviscross Awaiting requested review from traviscross

Assignees

@traviscross traviscross

Labels
A-run-make Area: port run-make Makefiles to rmake.rs F-explicit_extern_abis `#![feature(explicit_extern_abis)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@obeis @rustbot @traviscross @rust-log-analyzer @workingjubilee @bors @compiler-errors @ytmimi @Amanieu @wesleywiser