Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 3722: Explicit ABIs in extern #134986

Open
3 of 8 tasks
traviscross opened this issue Dec 31, 2024 · 6 comments
Open
3 of 8 tasks

Tracking issue for RFC 3722: Explicit ABIs in extern #134986

traviscross opened this issue Dec 31, 2024 · 6 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-explicit_extern_abis `#![feature(explicit_extern_abis)]` T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Dec 31, 2024

This is a tracking issue for:

The feature gate for the issue is #![feature(explicit_extern_abis)].

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

None.

Related

TODO.

Implementation history

TODO.

@traviscross traviscross added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue. F-explicit_extern_abis `#![feature(explicit_extern_abis)]` labels Dec 31, 2024
@obeis
Copy link
Contributor

obeis commented Jan 9, 2025

I have started working on implementing the RFC, and I will probably address a PR in the next two weeks.

@compiler-errors
Copy link
Member

Is this not already implemented as the MISSING_ABI lint? cc @m-ou-se

@m-ou-se
Copy link
Member

m-ou-se commented Jan 10, 2025

Yes, it is already implemented as a lint.

I assume this tracking issue is for making it a hard error in the next edition?

@compiler-errors
Copy link
Member

compiler-errors commented Jan 10, 2025

Yeah, I just wanted @obeis and @traviscross to be aware that this functionality is already implemented. It would be nice to have a PR to set it to deny in the new edition and implements a migration, though that is also dependent on a PR that adds the new edition (2027).

@m-ou-se
Copy link
Member

m-ou-se commented Jan 10, 2025

I already added a machine applicable suggestion to the lint, so the migration part is already done. The lint just needs to be added to the edition migration lint group at some point

@traviscross
Copy link
Contributor Author

The tracking issue steps above are now updated with the relevant work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-explicit_extern_abis `#![feature(explicit_extern_abis)]` T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants