Added fixes for ament_mypy (#5382)

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

Author: leander-dsouza

nav2_loopback_sim/nav2_loopback_sim/loopback_simulator.py

@@ -314,12 +314,12 @@ def getMap(self) -> None:
                 self.map = result.map
                 self.get_logger().info('Laser scan will be populated using map data')
             else:
-                self.get_logger().warn(
+                self.get_logger().warning(
                     'Failed to get map, '
                     'Laser scan will be populated using max range'
                 )
         else:
-            self.get_logger().warn(
+            self.get_logger().warning(
                 'Failed to get map, '
                 'Laser scan will be populated using max range'
             )

nav2_simple_commander/nav2_simple_commander/robot_navigator.py

@@ -34,7 +34,7 @@
                            ManageLifecycleNodes)
 from nav_msgs.msg import Goals, OccupancyGrid, Path
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.action.client import ClientGoalHandle
 from rclpy.client import Client
 from rclpy.duration import Duration as rclpyDuration
@@ -1242,7 +1242,7 @@ def info(self, msg: str) -> None:
         return
 
     def warn(self, msg: str) -> None:
-        self.get_logger().warn(msg)
+        self.get_logger().warning(msg)
         return
 
     def error(self, msg: str) -> None:

nav2_system_tests/src/behaviors/backup/backup_tester.py

@@ -23,7 +23,7 @@
 from nav2_msgs.msg import Costmap
 from nav2_msgs.srv import ManageLifecycleNodes
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.action.client import ClientGoalHandle
 from rclpy.client import Client
 from rclpy.duration import Duration
@@ -313,7 +313,7 @@ def info_msg(self, msg: str) -> None:
         self.get_logger().info(msg)
 
     def warn_msg(self, msg: str) -> None:
-        self.get_logger().warn(msg)
+        self.get_logger().warning(msg)
 
     def error_msg(self, msg: str) -> None:
         self.get_logger().error(msg)

nav2_system_tests/src/behaviors/drive_on_heading/drive_tester.py

@@ -23,7 +23,7 @@
 from nav2_msgs.msg import Costmap
 from nav2_msgs.srv import ManageLifecycleNodes
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.action.client import ClientGoalHandle
 from rclpy.client import Client
 from rclpy.duration import Duration
@@ -322,7 +322,7 @@ def info_msg(self, msg: str) -> None:
         self.get_logger().info(msg)
 
     def warn_msg(self, msg: str) -> None:
-        self.get_logger().warn(msg)
+        self.get_logger().warning(msg)
 
     def error_msg(self, msg: str) -> None:
         self.get_logger().error(msg)

nav2_system_tests/src/behaviors/spin/spin_tester.py

@@ -23,7 +23,7 @@
 from nav2_msgs.msg import Costmap
 from nav2_msgs.srv import ManageLifecycleNodes
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.action.client import ClientGoalHandle
 from rclpy.client import Client
 from rclpy.duration import Duration
@@ -303,7 +303,7 @@ def info_msg(self, msg: str) -> None:
         self.get_logger().info(msg)
 
     def warn_msg(self, msg: str) -> None:
-        self.get_logger().warn(msg)
+        self.get_logger().warning(msg)
 
     def error_msg(self, msg: str) -> None:
         self.get_logger().error(msg)

nav2_system_tests/src/costmap_filters/tester_node.py

@@ -30,7 +30,7 @@
 from nav2_msgs.srv import ManageLifecycleNodes
 from nav_msgs.msg import OccupancyGrid, Path
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.client import Client
 from rclpy.node import Node
 from rclpy.qos import QoSDurabilityPolicy, QoSHistoryPolicy, QoSProfile, QoSReliabilityPolicy
@@ -160,7 +160,7 @@ def info_msg(self, msg: str) -> None:
         self.get_logger().info('\033[1;37;44m' + msg + '\033[0m')
 
     def warn_msg(self, msg: str) -> None:
-        self.get_logger().warn('\033[1;37;43m' + msg + '\033[0m')
+        self.get_logger().warning('\033[1;37;43m' + msg + '\033[0m')
 
     def error_msg(self, msg: str) -> None:
         self.get_logger().error('\033[1;37;41m' + msg + '\033[0m')

nav2_system_tests/src/gps_navigation/tester.py

@@ -23,7 +23,7 @@
 from nav2_msgs.srv import ManageLifecycleNodes
 from rcl_interfaces.srv import SetParameters
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.action.client import ClientGoalHandle
 from rclpy.client import Client
 from rclpy.node import Node
@@ -155,7 +155,7 @@ def info_msg(self, msg: str) -> None:
         self.get_logger().info(msg)
 
     def warn_msg(self, msg: str) -> None:
-        self.get_logger().warn(msg)
+        self.get_logger().warning(msg)
 
     def error_msg(self, msg: str) -> None:
         self.get_logger().error(msg)

nav2_system_tests/src/route/tester_node.py

@@ -25,7 +25,7 @@
 from nav2_msgs.srv import ManageLifecycleNodes
 from nav2_simple_commander.robot_navigator import BasicNavigator
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.client import Client
 from rclpy.node import Node
 from rclpy.qos import QoSDurabilityPolicy, QoSHistoryPolicy, QoSProfile, QoSReliabilityPolicy

nav2_system_tests/src/system/nav_through_poses_tester_node.py

@@ -25,7 +25,7 @@
 from nav2_msgs.action import NavigateThroughPoses
 from nav2_msgs.srv import ManageLifecycleNodes
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.client import Client
 from rclpy.node import Node
 from rclpy.qos import QoSDurabilityPolicy, QoSHistoryPolicy, QoSProfile, QoSReliabilityPolicy
@@ -62,7 +62,7 @@ def info_msg(self, msg: str) -> None:
         self.get_logger().info('\033[1;37;44m' + msg + '\033[0m')
 
     def warn_msg(self, msg: str) -> None:
-        self.get_logger().warn('\033[1;37;43m' + msg + '\033[0m')
+        self.get_logger().warning('\033[1;37;43m' + msg + '\033[0m')
 
     def error_msg(self, msg: str) -> None:
         self.get_logger().error('\033[1;37;41m' + msg + '\033[0m')

nav2_system_tests/src/system/nav_to_pose_tester_node.py

@@ -29,7 +29,7 @@
 from nav2_msgs.action import NavigateToPose
 from nav2_msgs.srv import ManageLifecycleNodes
 import rclpy
-from rclpy.action import ActionClient  # type: ignore[attr-defined]
+from rclpy.action import ActionClient
 from rclpy.client import Client
 from rclpy.node import Node
 from rclpy.qos import QoSDurabilityPolicy, QoSHistoryPolicy, QoSProfile, QoSReliabilityPolicy
@@ -69,7 +69,7 @@ def info_msg(self, msg: str) -> None:
         self.get_logger().info('\033[1;37;44m' + msg + '\033[0m')
 
     def warn_msg(self, msg: str) -> None:
-        self.get_logger().warn('\033[1;37;43m' + msg + '\033[0m')
+        self.get_logger().warning('\033[1;37;43m' + msg + '\033[0m')
 
     def error_msg(self, msg: str) -> None:
         self.get_logger().error('\033[1;37;41m' + msg + '\033[0m')