feature: Navigation.setParams #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommmyy
force-pushed
the
feature_navigation__setParams
branch
from
061ae60 to
cc4e4c0
Compare
cknitt
requested changes
Nov 7, 2019
src/Navigation.re
Outdated
| @@ -34,7 +34,7 @@ external addListener: | |||
| EventSubscription.t = | |||
| "addListener"; | |||
|
|
|||
| // TODO: setParams, ... | |||
| [@bs.send] external setParams: (t, 'a) => unit = ""; | |||
There was a problem hiding this comment.
I would use Js.t('a) instead of 'a here
There was a problem hiding this comment.
Yes, It makes sense. And for the sake of #11 I will add name too.
tommmyy
force-pushed
the
feature_navigation__setParams
branch
from
cc4e4c0 to
442add7
Compare
tommmyy
force-pushed
the
feature_navigation__setParams
branch
from
442add7 to
39687a7
Compare
cknitt
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My motivation:
https://reactnavigation.org/docs/en/header-buttons.html#header-interaction-with-its-screen-component