-
-
Notifications
You must be signed in to change notification settings - Fork 31
Add value name to bindings #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value name to bindings #11
Conversation
Makes ffi declarations less fragile to refactoring.
@slamberg94 Is refmt removing newlines or is your editor doing that? |
@MoOx his editor. I just checked out the branch and ran |
|
[@bs.send] external toggleDrawer: t => unit = ""; | ||
[@bs.send] external openDrawer: t => unit = "openDrawer"; | ||
[@bs.send] external closeDrawer: t => unit = "closeDrawer"; | ||
[@bs.send] external toggleDrawer: t => unit = "toggleDrawer"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[@bs.send] external toggleDrawer: t => unit = "toggleDrawer"; | |
[@bs.send] external toggleDrawer: t => unit = "toggleDrawer"; | |
|
||
[@bs.module "react-navigation"] [@bs.scope "NavigationActions"] | ||
external back: backParams => action = ""; | ||
external back: backParams => action = "back"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
external back: backParams => action = "back"; | |
external back: backParams => action = "back"; | |
@@ -1,2 +1,3 @@ | |||
type t; | |||
[@bs.send] external dispatch: (t, NavigationActions.action) => unit = ""; | |||
[@bs.send] | |||
external dispatch: (t, NavigationActions.action) => unit = "dispatch"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
external dispatch: (t, NavigationActions.action) => unit = "dispatch"; | |
external dispatch: (t, NavigationActions.action) => unit = "dispatch"; | |
Makes ffi declarations less fragile to refactoring.