Skip to content

Add value name to bindings #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

slamberg94
Copy link

Makes ffi declarations less fragile to refactoring.

Makes ffi declarations less fragile to refactoring.
@MoOx MoOx requested a review from cknitt October 14, 2019 10:04
@MoOx
Copy link
Member

MoOx commented Oct 22, 2019

@slamberg94 Is refmt removing newlines or is your editor doing that?

@Natim
Copy link
Contributor

Natim commented Oct 24, 2019

@MoOx his editor. I just checked out the branch and ran yarn format and it fixed it.

@Natim
Copy link
Contributor

Natim commented Oct 24, 2019

diff --git a/src/Navigation.re b/src/Navigation.re
index 0d440f7..b67ef5a 100644
--- a/src/Navigation.re
+++ b/src/Navigation.re
@@ -43,4 +43,4 @@ external addListener:
 // Drawer navigator only
 [@bs.send] external openDrawer: t => unit = "openDrawer";
 [@bs.send] external closeDrawer: t => unit = "closeDrawer";
-[@bs.send] external toggleDrawer: t => unit = "toggleDrawer";
\ No newline at end of file
+[@bs.send] external toggleDrawer: t => unit = "toggleDrawer";
diff --git a/src/NavigationActions.re b/src/NavigationActions.re
index 4751b06..79a9c2e 100644
--- a/src/NavigationActions.re
+++ b/src/NavigationActions.re
@@ -18,4 +18,4 @@ external backParams:
 external navigate: navigateParams => action = "navigate";
 
 [@bs.module "react-navigation"] [@bs.scope "NavigationActions"]
-external back: backParams => action = "back";
\ No newline at end of file
+external back: backParams => action = "back";
diff --git a/src/NavigationContainer.re b/src/NavigationContainer.re
index 9bc5d89..55229f0 100644
--- a/src/NavigationContainer.re
+++ b/src/NavigationContainer.re
@@ -1,3 +1,3 @@
 type t;
 [@bs.send]
-external dispatch: (t, NavigationActions.action) => unit = "dispatch";
\ No newline at end of file
+external dispatch: (t, NavigationActions.action) => unit = "dispatch";

[@bs.send] external toggleDrawer: t => unit = "";
[@bs.send] external openDrawer: t => unit = "openDrawer";
[@bs.send] external closeDrawer: t => unit = "closeDrawer";
[@bs.send] external toggleDrawer: t => unit = "toggleDrawer";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[@bs.send] external toggleDrawer: t => unit = "toggleDrawer";
[@bs.send] external toggleDrawer: t => unit = "toggleDrawer";


[@bs.module "react-navigation"] [@bs.scope "NavigationActions"]
external back: backParams => action = "";
external back: backParams => action = "back";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
external back: backParams => action = "back";
external back: backParams => action = "back";

@@ -1,2 +1,3 @@
type t;
[@bs.send] external dispatch: (t, NavigationActions.action) => unit = "";
[@bs.send]
external dispatch: (t, NavigationActions.action) => unit = "dispatch";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
external dispatch: (t, NavigationActions.action) => unit = "dispatch";
external dispatch: (t, NavigationActions.action) => unit = "dispatch";

@MoOx MoOx closed this Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants