Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test output #7331

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Update test output #7331

merged 2 commits into from
Mar 11, 2025

Conversation

zth
Copy link
Collaborator

@zth zth commented Mar 11, 2025

Might be worth investigating at some point why this isn't caught in tests, that the output has actually changed.

@zth zth requested review from cknitt and cristianoc March 11, 2025 19:04
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 88f1ce7 Previous: 80744a5 Ratio
Print RedBlackTree.res - time/run 3.166387193333333 ms 2.9391152133333334 ms 1.08
Print RedBlackTreeNoComments.res - time/run 2.88698546 ms 2.693127673333333 ms 1.07
Parse Napkinscript.res - time/run 66.50558359333333 ms 60.98575317999999 ms 1.09
Print Napkinscript.res - time/run 110.40779337333333 ms 102.03488166 ms 1.08
Parse HeroGraphic.res - time/run 8.088808639999998 ms 7.62831228 ms 1.06
Print HeroGraphic.res - time/run 13.714620333333333 ms 12.308145193333333 ms 1.11

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt
Copy link
Member

cknitt commented Mar 11, 2025

Might be worth investigating at some point why this isn't caught in tests, that the output has actually changed.

Yes, will check that.

@zth zth merged commit 44d45f5 into master Mar 11, 2025
20 checks passed
@zth zth deleted the update-test-output branch March 11, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants