Skip to content

Commit 80744a5

Browse files
cknittzth
andauthoredFeb 17, 2025
Stdlib namespace for Core modules (#7285)
* Stdlib namespace for Core modules * fix gentype output * commit another test * commit new test output (that has errors) * pipe completion for stdlib * pick up another regex completion * handle nopervasives, and open Stdlib by default * commit more tests * Reanalyze tests working again * Fix Gentype for real * Do not run analysis tests on Linux * Cache reanalyze, too * CHANGELOG --------- Co-authored-by: Gabriel Nordeborn <gabbe.nord@gmail.com>
1 parent 70a73ed commit 80744a5

File tree

311 files changed

+3089
-2230
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

311 files changed

+3089
-2230
lines changed
 

‎.github/workflows/ci.yml

+7-5
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ jobs:
153153
# matrix.ocaml_compiler may contain commas
154154
- name: Get OPAM cache key
155155
shell: bash
156-
run: echo "opam_cache_key=opam-env-v6-${{ matrix.os }}-${{ matrix.ocaml_compiler }}-${{ hashFiles('dune-project') }}" | sed 's/,/-/g' >> $GITHUB_ENV
156+
run: echo "opam_cache_key=opam-env-v7-${{ matrix.os }}-${{ matrix.ocaml_compiler }}-${{ hashFiles('dune-project') }}" | sed 's/,/-/g' >> $GITHUB_ENV
157157

158158
- name: Restore OPAM environment
159159
id: cache-opam-env
@@ -191,6 +191,10 @@ jobs:
191191
if: steps.cache-opam-env.outputs.cache-hit != 'true'
192192
run: opam install . --deps-only --with-test
193193

194+
- name: "Install reanalyze"
195+
if: steps.cache-opam-env.outputs.cache-hit != 'true' && matrix.run_reanalyze
196+
run: opam install reanalyze
197+
194198
- name: Cache OPAM environment
195199
if: steps.cache-opam-env.outputs.cache-hit != 'true'
196200
uses: actions/cache/save@v4
@@ -303,9 +307,7 @@ jobs:
303307

304308
- name: "Syntax: Run reanalyze"
305309
if: matrix.run_reanalyze
306-
run: |
307-
opam install reanalyze
308-
opam exec -- make reanalyze
310+
run: opam exec -- make reanalyze
309311

310312
- name: Build runtime/stdlib
311313
run: ./scripts/buildRuntime.sh
@@ -324,7 +326,7 @@ jobs:
324326
run: git diff --ignore-cr-at-eol --exit-code tests
325327

326328
- name: Run analysis / tools tests
327-
if: runner.os != 'Windows' && matrix.os != 'ubuntu-24.04-arm'
329+
if: runner.os != 'Windows' && runner.os != 'Linux'
328330
run: opam exec -- make -C tests/analysis_tests test && make -C tests/tools_tests test
329331

330332
- name: Run gentype tests

‎CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
- Fix completion for application with tagged template. https://github.com/rescript-lang/rescript/pull/7278
2626
- Fix error message for arity in the presence of optional arguments. https://github.com/rescript-lang/rescript/pull/7284
2727
- Fix issue in functors with more than one argument (which are curried): emit nested function always. https://github.com/rescript-lang/rescript/pull/7273
28-
- Fix dot completion issue with React primitives. https://github.com/rescript-lang/rescript/pull/7292
28+
- Fix dot completion issue with React primitives. https://github.com/rescript-lang/rescript/pull/7292
29+
- Stdlib namespace for Core modules (fixes name clashes with user modules). https://github.com/rescript-lang/rescript/pull/7285
2930

3031
#### :house: Internal
3132

0 commit comments

Comments
 (0)