Fix recursive untagged variant type checking #7320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 627aa90 | Previous: 80744a5 | Ratio |
|---|---|---|---|
Print RedBlackTree.res - time/run |
3.153901073333333 ms |
2.9391152133333334 ms |
1.07 |
Parse Napkinscript.res - time/run |
65.47556327333334 ms |
60.98575317999999 ms |
1.07 |
Print Napkinscript.res - time/run |
107.23577804 ms |
102.03488166 ms |
1.05 |
Print HeroGraphic.res - time/run |
13.569018213333333 ms |
12.308145193333333 ms |
1.10 |
This comment was automatically generated by workflow using github-action-benchmark.
cristianoc
force-pushed
the
untagged_recursive_check
branch
from
57f785d to
b57e66e
Compare
cknitt
reviewed
Mar 6, 2025
Fixes #7314 - Delay untagged variant well-formedness checks until after environment construction - Collect all untagged variant checks during type declaration processing - Perform checks once all recursive types are available in the environment - Add test case for valid recursive untagged variant type definitions This fixes issues where recursive references in untagged variants would fail validation due to premature checking before the full type environment was built.
cristianoc
force-pushed
the
untagged_recursive_check
branch
from
b57e66e to
627aa90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7314
This fixes issues where recursive references in untagged variants would fail validation due to premature checking before the full type environment was built.