Bundle stdlib runtime for playground #7255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 5af9419 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.36702038 ms |
1.2123143266666667 ms |
1.13 |
Parse Napkinscript.res - time/run |
42.357428 ms |
39.28006235333333 ms |
1.08 |
Parse HeroGraphic.res - time/run |
6.391031979999999 ms |
5.13472718 ms |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
| @@ -75,7 +75,7 @@ function buildCompilerCmij() { | |||
| } | |||
|
|
|||
| e( | |||
| `find ${rescriptLibOcamlFolder} -name "*.cmi" -or -name "*.cmj" | xargs -n1 basename | xargs js_of_ocaml build-fs -o ${cmijFile} -I ${rescriptLibOcamlFolder}`, | |||
| `find ${rescriptLibOcamlFolder} -name "*.cmi" -or -name "*.cmj" | xargs -n1 basename | xargs js_of_ocaml build-fs -o ${cmijFile} -I ${rescriptLibOcamlFolder}` | |||
There was a problem hiding this comment.
I really thought this line would need to be changed, but I am glad this is just formatting.
There was a problem hiding this comment.
@fhammerschmidt would you like the formatting noise to be removed?
| @@ -31,7 +31,7 @@ let string_of_module_id_in_browser (x : Lam_module_ident.t) = | |||
| match x.kind with | |||
| | External {name} -> name | |||
| | Runtime | Ml -> | |||
| "./stdlib/" ^ Ext_string.uncapitalize_ascii x.id.name ^ ".js" | |||
| "./stdlib/" ^ x.id.name ^ ".js" | |||
There was a problem hiding this comment.
are you sure this can go away for both Ml and Runtime?
There was a problem hiding this comment.
I think this is only used in the playground so it should be safe. It was invalid before.
fhammerschmidt
requested changes
Jan 25, 2025
fhammerschmidt
approved these changes
Jan 25, 2025
tsnobip
added a commit
that referenced
this pull request
Jan 27, 2025
tsnobip
added a commit
that referenced
this pull request
Jan 27, 2025
fhammerschmidt
pushed a commit
that referenced
this pull request
Jan 27, 2025
tsnobip
added a commit
that referenced
this pull request
Jan 31, 2025
tsnobip
added a commit
that referenced
this pull request
Jan 31, 2025
cknitt
added a commit
that referenced
this pull request
Feb 1, 2025
* backport bundle stdlib JS files for playground (#7255) * replace deprecated pipes with shlex * update setup-ocaml * use node 18 * add rollup linux as an optional dependency * use ubuntu-24.04 and ubuntu-24.04-arm * backport fix for hanging tests (#6667) * update artifacts.txt * backport: CI: don't run npm pack twice (#6923) * CI: don't run npm pack twice * Add typedefs for PackOutput * Update comments * update artifacts * Fix CHANGELOG.md --------- Co-authored-by: Christoph Knittel <ck@cca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To load stdlib JS files in the playground, we need to bundle them and upload them to the CDN.