CI: don't run npm pack twice #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we still need to manage the artifact list? |
cometkim
reviewed
Jul 29, 2024
cristianoc
approved these changes
Jul 29, 2024
I would definitely like to keep it, it already saved us a few times from unexpected files ending up in the npm package. |
tsnobip
pushed a commit
that referenced
this pull request
Jan 31, 2025
* CI: don't run npm pack twice * Add typedefs for PackOutput * Update comments
tsnobip
pushed a commit
that referenced
this pull request
Jan 31, 2025
* CI: don't run npm pack twice * Add typedefs for PackOutput * Update comments
cknitt
added a commit
that referenced
this pull request
Feb 1, 2025
* backport bundle stdlib JS files for playground (#7255) * replace deprecated pipes with shlex * update setup-ocaml * use node 18 * add rollup linux as an optional dependency * use ubuntu-24.04 and ubuntu-24.04-arm * backport fix for hanging tests (#6667) * update artifacts.txt * backport: CI: don't run npm pack twice (#6923) * CI: don't run npm pack twice * Add typedefs for PackOutput * Update comments * update artifacts * Fix CHANGELOG.md --------- Co-authored-by: Christoph Knittel <ck@cca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm packwas run twice. Once with--dry-runto check the artifact list, and one more time for the actual package creation.Doing it only once saves another 12s in CI.