Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST: Remove Pexp_new #7239

Merged
merged 9 commits into from
Jan 11, 2025
Merged

AST: Remove Pexp_new #7239

merged 9 commits into from
Jan 11, 2025

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Jan 10, 2025

Pexp_new is not used in the untyped tree.

@nojaf nojaf changed the title Remove Pexp_new AST: Remove Pexp_new Jan 10, 2025
@nojaf nojaf marked this pull request as ready for review January 10, 2025 16:29
cristianoc
cristianoc reviewed Jan 10, 2025
View reviewed changes
cristianoc
cristianoc approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet cleanup!

@cristianoc
Copy link
Collaborator

Actually, there's also Texp_new, Texp_override, Texp_setinstvar, and Texp_poly which now become unused.

@nojaf
Remove exp_extra.Texp_poly, expression_desc.Texp_new, `expression…
195ae43 
…_desc.Texp_setinstvar` & `expression_desc.Texp_override`
@nojaf
Copy link
Collaborator Author

nojaf commented Jan 10, 2025

Yup, checks out!

cknitt
cknitt approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@cristianoc cristianoc merged commit c2ad39e into rescript-lang:master Jan 11, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @cristianoc @cknitt