Skip to content

Commit c2ad39e

Browse files
nojafcristianoc
nojaf
and
cristianoc
authored
AST: Remove Pexp_new (#7239)
* Remove Pexp_new * Add changelog entry * Remove Pexp_setinstvar * Remove Pexp_override * Try removing Pexp_poly * Correct changelog * Remove `exp_extra.Texp_poly`, `expression_desc.Texp_new`, `expression_desc.Texp_setinstvar` & `expression_desc.Texp_override` * Remove expression_desc.Texp_instvar --------- Co-authored-by: Cristiano Calcagno <cristianoc@users.noreply.github.com>
1 parent e96f2f2 commit c2ad39e

28 files changed

+13
-224
lines changed

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
- AST cleanup: Prepare for ast async cleanup: Refactor code for "@res.async" payload handling and clean up handling of type and term parameters, so that now each `=>` in a function definition corresponds to a function. https://github.com/rescript-lang/rescript/pull/7223
2525
- AST: always put type parameters first in function definitions. https://github.com/rescript-lang/rescript/pull/7233
2626
- AST cleanup: Remove `@res.async` attribute from the internal representation, and add a flag to untyped and typed ASTs instead. https://github.com/rescript-lang/rescript/pull/7234
27+
- AST cleanup: Remove `expression_desc.Pexp_new`, `expression_desc.Pexp_setinstvar`, `expression_desc.Pexp_override`, `expression_desc.Pexp_poly`, `exp_extra.Texp_poly`, `expression_desc.Texp_new`, `expression_desc.Texp_setinstvar`, `expression_desc.Texp_override` & `expression_desc.Texp_instvar` from AST as it is unused. https://github.com/rescript-lang/rescript/pull/7239
2728
- AST cleanup: Remove `@res.partial` attribute from the internal representation, and add a flag to untyped and typed ASTs instead. https://github.com/rescript-lang/rescript/pull/7238 https://github.com/rescript-lang/rescript/pull/7240
2829

2930
# 12.0.0-alpha.7

‎analysis/reanalyze/src/Arnold.ml

-12
Original file line numberDiff line numberDiff line change
@@ -982,18 +982,6 @@ module Compile = struct
982982
| Texp_send _ ->
983983
notImplemented "Texp_send";
984984
assert false
985-
| Texp_new _ ->
986-
notImplemented "Texp_new";
987-
assert false
988-
| Texp_instvar _ ->
989-
notImplemented "Texp_instvar";
990-
assert false
991-
| Texp_setinstvar _ ->
992-
notImplemented "Texp_setinstvar";
993-
assert false
994-
| Texp_override _ ->
995-
notImplemented "Texp_override";
996-
assert false
997985
| Texp_letmodule _ ->
998986
notImplemented "Texp_letmodule";
999987
assert false

‎analysis/reanalyze/src/SideEffects.ml

-4
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ let rec exprNoSideEffects (expr : Typedtree.expression) =
6161
e1 |> exprNoSideEffects && e2 |> exprNoSideEffects
6262
&& e3 |> exprNoSideEffects
6363
| Texp_send _ -> false
64-
| Texp_new _ -> true
65-
| Texp_instvar _ -> true
66-
| Texp_setinstvar _ -> false
67-
| Texp_override _ -> false
6864
| Texp_letexception (_ec, e) -> e |> exprNoSideEffects
6965
| Texp_pack _ -> false
7066
| Texp_extension_constructor _ when true -> true

‎analysis/src/Utils.ml

-4
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,10 @@ let identifyPexp pexp =
103103
| Pexp_constraint _ -> "Pexp_constraint"
104104
| Pexp_coerce _ -> "Pexp_coerce"
105105
| Pexp_send _ -> "Pexp_send"
106-
| Pexp_new _ -> "Pexp_new"
107-
| Pexp_setinstvar _ -> "Pexp_setinstvar"
108-
| Pexp_override _ -> "Pexp_override"
109106
| Pexp_letmodule _ -> "Pexp_letmodule"
110107
| Pexp_letexception _ -> "Pexp_letexception"
111108
| Pexp_assert _ -> "Pexp_assert"
112109
| Pexp_lazy _ -> "Pexp_lazy"
113-
| Pexp_poly _ -> "Pexp_poly"
114110
| Pexp_newtype _ -> "Pexp_newtype"
115111
| Pexp_pack _ -> "Pexp_pack"
116112
| Pexp_extension _ -> "Pexp_extension"

‎compiler/frontend/bs_ast_invariant.ml

-2
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,6 @@ let emit_external_warnings : iterator =
9494
(fun self ({pexp_loc = loc} as a) ->
9595
match a.pexp_desc with
9696
| Pexp_constant const -> check_constant loc const
97-
| Pexp_new _ ->
98-
Location.raise_errorf ~loc "OCaml style objects are not supported"
9997
| Pexp_variant (s, None) when Ext_string.is_valid_hash_number s -> (
10098
try ignore (Ext_string.hash_number_as_i32_exn s : int32)
10199
with _ ->

‎compiler/frontend/bs_ast_mapper.ml

-8
Original file line numberDiff line numberDiff line change
@@ -355,12 +355,6 @@ module E = struct
355355
| Pexp_constraint (e, t) ->
356356
constraint_ ~loc ~attrs (sub.expr sub e) (sub.typ sub t)
357357
| Pexp_send (e, s) -> send ~loc ~attrs (sub.expr sub e) (map_loc sub s)
358-
| Pexp_new lid -> new_ ~loc ~attrs (map_loc sub lid)
359-
| Pexp_setinstvar (s, e) ->
360-
setinstvar ~loc ~attrs (map_loc sub s) (sub.expr sub e)
361-
| Pexp_override sel ->
362-
override ~loc ~attrs
363-
(List.map (map_tuple (map_loc sub) (sub.expr sub)) sel)
364358
| Pexp_letmodule (s, me, e) ->
365359
letmodule ~loc ~attrs (map_loc sub s) (sub.module_expr sub me)
366360
(sub.expr sub e)
@@ -370,8 +364,6 @@ module E = struct
370364
(sub.expr sub e)
371365
| Pexp_assert e -> assert_ ~loc ~attrs (sub.expr sub e)
372366
| Pexp_lazy e -> lazy_ ~loc ~attrs (sub.expr sub e)
373-
| Pexp_poly (e, t) ->
374-
poly ~loc ~attrs (sub.expr sub e) (map_opt (sub.typ sub) t)
375367
| Pexp_newtype (s, e) ->
376368
newtype ~loc ~attrs (map_loc sub s) (sub.expr sub e)
377369
| Pexp_pack me -> pack ~loc ~attrs (sub.module_expr sub me)

‎compiler/frontend/bs_builtin_ppx.ml

-18
Original file line numberDiff line numberDiff line change
@@ -87,24 +87,6 @@ let expr_mapper ~async_context ~in_function_def (self : mapper)
8787
(* Its output should not be rewritten anymore *)
8888
| Pexp_extension extension ->
8989
Ast_exp_extension.handle_extension e self extension
90-
| Pexp_setinstvar ({txt; loc}, expr) ->
91-
if Stack.is_empty Js_config.self_stack then
92-
Location.raise_errorf ~loc:e.pexp_loc
93-
"This assignment can only happen in object context";
94-
let name = Stack.top Js_config.self_stack in
95-
if name = "" then
96-
Location.raise_errorf ~loc:e.pexp_loc
97-
"The current object does not assign a name";
98-
let open Ast_helper in
99-
self.expr self
100-
(Exp.apply ~loc:e.pexp_loc
101-
(Exp.ident ~loc {loc; txt = Lident "#="})
102-
[
103-
( Nolabel,
104-
Exp.send ~loc (Exp.ident ~loc {loc; txt = Lident name}) {loc; txt}
105-
);
106-
(Nolabel, expr);
107-
])
10890
| Pexp_constant (Pconst_string (s, Some delim)) ->
10991
Ast_utf8_string_interp.transform_exp e s delim
11092
| Pexp_constant (Pconst_integer (s, Some 'l')) ->

‎compiler/ml/ast_helper.ml

-4
Original file line numberDiff line numberDiff line change
@@ -172,14 +172,10 @@ module Exp = struct
172172
let constraint_ ?loc ?attrs a b = mk ?loc ?attrs (Pexp_constraint (a, b))
173173
let coerce ?loc ?attrs a c = mk ?loc ?attrs (Pexp_coerce (a, (), c))
174174
let send ?loc ?attrs a b = mk ?loc ?attrs (Pexp_send (a, b))
175-
let new_ ?loc ?attrs a = mk ?loc ?attrs (Pexp_new a)
176-
let setinstvar ?loc ?attrs a b = mk ?loc ?attrs (Pexp_setinstvar (a, b))
177-
let override ?loc ?attrs a = mk ?loc ?attrs (Pexp_override a)
178175
let letmodule ?loc ?attrs a b c = mk ?loc ?attrs (Pexp_letmodule (a, b, c))
179176
let letexception ?loc ?attrs a b = mk ?loc ?attrs (Pexp_letexception (a, b))
180177
let assert_ ?loc ?attrs a = mk ?loc ?attrs (Pexp_assert a)
181178
let lazy_ ?loc ?attrs a = mk ?loc ?attrs (Pexp_lazy a)
182-
let poly ?loc ?attrs a b = mk ?loc ?attrs (Pexp_poly (a, b))
183179
let newtype ?loc ?attrs a b = mk ?loc ?attrs (Pexp_newtype (a, b))
184180
let pack ?loc ?attrs a = mk ?loc ?attrs (Pexp_pack a)
185181
let open_ ?loc ?attrs a b c = mk ?loc ?attrs (Pexp_open (a, b, c))

‎compiler/ml/ast_helper.mli

-6
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,6 @@ module Exp : sig
193193
val constraint_ :
194194
?loc:loc -> ?attrs:attrs -> expression -> core_type -> expression
195195
val send : ?loc:loc -> ?attrs:attrs -> expression -> str -> expression
196-
val new_ : ?loc:loc -> ?attrs:attrs -> lid -> expression
197-
val setinstvar : ?loc:loc -> ?attrs:attrs -> str -> expression -> expression
198-
val override :
199-
?loc:loc -> ?attrs:attrs -> (str * expression) list -> expression
200196
val letmodule :
201197
?loc:loc -> ?attrs:attrs -> str -> module_expr -> expression -> expression
202198
val letexception :
@@ -207,8 +203,6 @@ module Exp : sig
207203
expression
208204
val assert_ : ?loc:loc -> ?attrs:attrs -> expression -> expression
209205
val lazy_ : ?loc:loc -> ?attrs:attrs -> expression -> expression
210-
val poly :
211-
?loc:loc -> ?attrs:attrs -> expression -> core_type option -> expression
212206
val newtype : ?loc:loc -> ?attrs:attrs -> str -> expression -> expression
213207
val pack : ?loc:loc -> ?attrs:attrs -> module_expr -> expression
214208
val open_ :

‎compiler/ml/ast_iterator.ml

-9
Original file line numberDiff line numberDiff line change
@@ -333,12 +333,6 @@ module E = struct
333333
sub.expr sub e;
334334
sub.typ sub t
335335
| Pexp_send (e, _s) -> sub.expr sub e
336-
| Pexp_new lid -> iter_loc sub lid
337-
| Pexp_setinstvar (s, e) ->
338-
iter_loc sub s;
339-
sub.expr sub e
340-
| Pexp_override sel ->
341-
List.iter (iter_tuple (iter_loc sub) (sub.expr sub)) sel
342336
| Pexp_letmodule (s, me, e) ->
343337
iter_loc sub s;
344338
sub.module_expr sub me;
@@ -348,9 +342,6 @@ module E = struct
348342
sub.expr sub e
349343
| Pexp_assert e -> sub.expr sub e
350344
| Pexp_lazy e -> sub.expr sub e
351-
| Pexp_poly (e, t) ->
352-
sub.expr sub e;
353-
iter_opt (sub.typ sub) t
354345
| Pexp_newtype (_s, e) -> sub.expr sub e
355346
| Pexp_pack me -> sub.module_expr sub me
356347
| Pexp_open (_ovf, lid, e) ->

‎compiler/ml/ast_mapper.ml

-8
Original file line numberDiff line numberDiff line change
@@ -318,12 +318,6 @@ module E = struct
318318
| Pexp_constraint (e, t) ->
319319
constraint_ ~loc ~attrs (sub.expr sub e) (sub.typ sub t)
320320
| Pexp_send (e, s) -> send ~loc ~attrs (sub.expr sub e) (map_loc sub s)
321-
| Pexp_new lid -> new_ ~loc ~attrs (map_loc sub lid)
322-
| Pexp_setinstvar (s, e) ->
323-
setinstvar ~loc ~attrs (map_loc sub s) (sub.expr sub e)
324-
| Pexp_override sel ->
325-
override ~loc ~attrs
326-
(List.map (map_tuple (map_loc sub) (sub.expr sub)) sel)
327321
| Pexp_letmodule (s, me, e) ->
328322
letmodule ~loc ~attrs (map_loc sub s) (sub.module_expr sub me)
329323
(sub.expr sub e)
@@ -333,8 +327,6 @@ module E = struct
333327
(sub.expr sub e)
334328
| Pexp_assert e -> assert_ ~loc ~attrs (sub.expr sub e)
335329
| Pexp_lazy e -> lazy_ ~loc ~attrs (sub.expr sub e)
336-
| Pexp_poly (e, t) ->
337-
poly ~loc ~attrs (sub.expr sub e) (map_opt (sub.typ sub) t)
338330
| Pexp_newtype (s, e) ->
339331
newtype ~loc ~attrs (map_loc sub s) (sub.expr sub e)
340332
| Pexp_pack me -> pack ~loc ~attrs (sub.module_expr sub me)

‎compiler/ml/ast_mapper_from0.ml

+6-8
Original file line numberDiff line numberDiff line change
@@ -387,12 +387,11 @@ module E = struct
387387
| Pexp_constraint (e, t) ->
388388
constraint_ ~loc ~attrs (sub.expr sub e) (sub.typ sub t)
389389
| Pexp_send (e, s) -> send ~loc ~attrs (sub.expr sub e) (map_loc sub s)
390-
| Pexp_new lid -> new_ ~loc ~attrs (map_loc sub lid)
391-
| Pexp_setinstvar (s, e) ->
392-
setinstvar ~loc ~attrs (map_loc sub s) (sub.expr sub e)
393-
| Pexp_override sel ->
394-
override ~loc ~attrs
395-
(List.map (map_tuple (map_loc sub) (sub.expr sub)) sel)
390+
| Pexp_new _ -> failwith "Pexp_new is no longer present in ReScript"
391+
| Pexp_setinstvar _ ->
392+
failwith "Pexp_setinstvar is no longer present in ReScript"
393+
| Pexp_override _ ->
394+
failwith "Pexp_override is no longer present in ReScript"
396395
| Pexp_letmodule (s, me, e) ->
397396
letmodule ~loc ~attrs (map_loc sub s) (sub.module_expr sub me)
398397
(sub.expr sub e)
@@ -402,8 +401,7 @@ module E = struct
402401
(sub.expr sub e)
403402
| Pexp_assert e -> assert_ ~loc ~attrs (sub.expr sub e)
404403
| Pexp_lazy e -> lazy_ ~loc ~attrs (sub.expr sub e)
405-
| Pexp_poly (e, t) ->
406-
poly ~loc ~attrs (sub.expr sub e) (map_opt (sub.typ sub) t)
404+
| Pexp_poly _ -> failwith "Pexp_poly is no longer present in ReScript"
407405
| Pexp_object () -> assert false
408406
| Pexp_newtype (s, e) ->
409407
newtype ~loc ~attrs (map_loc sub s) (sub.expr sub e)

‎compiler/ml/ast_mapper_to0.ml

-8
Original file line numberDiff line numberDiff line change
@@ -369,12 +369,6 @@ module E = struct
369369
| Pexp_constraint (e, t) ->
370370
constraint_ ~loc ~attrs (sub.expr sub e) (sub.typ sub t)
371371
| Pexp_send (e, s) -> send ~loc ~attrs (sub.expr sub e) (map_loc sub s)
372-
| Pexp_new lid -> new_ ~loc ~attrs (map_loc sub lid)
373-
| Pexp_setinstvar (s, e) ->
374-
setinstvar ~loc ~attrs (map_loc sub s) (sub.expr sub e)
375-
| Pexp_override sel ->
376-
override ~loc ~attrs
377-
(List.map (map_tuple (map_loc sub) (sub.expr sub)) sel)
378372
| Pexp_letmodule (s, me, e) ->
379373
letmodule ~loc ~attrs (map_loc sub s) (sub.module_expr sub me)
380374
(sub.expr sub e)
@@ -384,8 +378,6 @@ module E = struct
384378
(sub.expr sub e)
385379
| Pexp_assert e -> assert_ ~loc ~attrs (sub.expr sub e)
386380
| Pexp_lazy e -> lazy_ ~loc ~attrs (sub.expr sub e)
387-
| Pexp_poly (e, t) ->
388-
poly ~loc ~attrs (sub.expr sub e) (map_opt (sub.typ sub) t)
389381
| Pexp_newtype (s, e) ->
390382
newtype ~loc ~attrs (map_loc sub s) (sub.expr sub e)
391383
| Pexp_pack me -> pack ~loc ~attrs (sub.module_expr sub me)

‎compiler/ml/depend.ml

-6
Original file line numberDiff line numberDiff line change
@@ -271,18 +271,12 @@ let rec add_expr bv exp =
271271
add_expr bv e1;
272272
add_type bv ty2
273273
| Pexp_send (e, _m) -> add_expr bv e
274-
| Pexp_new li -> add bv li
275-
| Pexp_setinstvar (_v, e) -> add_expr bv e
276-
| Pexp_override sel -> List.iter (fun (_s, e) -> add_expr bv e) sel
277274
| Pexp_letmodule (id, m, e) ->
278275
let b = add_module_binding bv m in
279276
add_expr (StringMap.add id.txt b bv) e
280277
| Pexp_letexception (_, e) -> add_expr bv e
281278
| Pexp_assert e -> add_expr bv e
282279
| Pexp_lazy e -> add_expr bv e
283-
| Pexp_poly (e, t) ->
284-
add_expr bv e;
285-
add_opt add_type bv t
286280
| Pexp_newtype (_, e) -> add_expr bv e
287281
| Pexp_pack m -> add_module bv m
288282
| Pexp_open (_ovf, m, e) ->

‎compiler/ml/parsetree.ml

-9
Original file line numberDiff line numberDiff line change
@@ -295,10 +295,6 @@ and expression_desc =
295295
(* (E :> T) (None, T)
296296
*)
297297
| Pexp_send of expression * label loc (* E # m *)
298-
| Pexp_new of Longident.t loc (* new M.c *)
299-
| Pexp_setinstvar of label loc * expression (* x <- 2 *)
300-
| Pexp_override of (label loc * expression) list
301-
(* {< x1 = E1; ...; Xn = En >} *)
302298
| Pexp_letmodule of string loc * module_expr * expression
303299
(* let module M = ME in E *)
304300
| Pexp_letexception of extension_constructor * expression
@@ -308,11 +304,6 @@ and expression_desc =
308304
Note: "assert false" is treated in a special way by the
309305
type-checker. *)
310306
| Pexp_lazy of expression (* lazy E *)
311-
| Pexp_poly of expression * core_type option
312-
(* Used for method bodies.
313-
314-
Can only be used as the expression under Cfk_concrete
315-
for methods (not values). *)
316307
| Pexp_newtype of string loc * expression (* fun (type t) -> E *)
317308
| Pexp_pack of module_expr
318309
(* (module ME)

‎compiler/ml/pprintast.ml

-15
Original file line numberDiff line numberDiff line change
@@ -706,15 +706,6 @@ and expression ctxt f x =
706706
in
707707
let lst = sequence_helper [] x in
708708
pp f "@[<hv>%a@]" (list (expression (under_semi ctxt)) ~sep:";@;") lst
709-
| Pexp_new li -> pp f "@[<hov2>new@ %a@]" longident_loc li
710-
| Pexp_setinstvar (s, e) ->
711-
pp f "@[<hov2>%s@ <-@ %a@]" s.txt (expression ctxt) e
712-
| Pexp_override l ->
713-
(* FIXME *)
714-
let string_x_expression f (s, e) =
715-
pp f "@[<hov2>%s@ =@ %a@]" s.txt (expression ctxt) e
716-
in
717-
pp f "@[<hov2>{<%a>}@]" (list string_x_expression ~sep:";") l
718709
| Pexp_letmodule (s, me, e) ->
719710
pp f "@[<hov2>let@ module@ %s@ =@ %a@ in@ %a@]" s.txt
720711
(module_expr reset_ctxt) me (expression ctxt) e
@@ -724,12 +715,6 @@ and expression ctxt f x =
724715
cd (expression ctxt) e
725716
| Pexp_assert e -> pp f "@[<hov2>assert@ %a@]" (simple_expr ctxt) e
726717
| Pexp_lazy e -> pp f "@[<hov2>lazy@ %a@]" (simple_expr ctxt) e
727-
(* Pexp_poly: impossible but we should print it anyway, rather than
728-
assert false *)
729-
| Pexp_poly (e, None) -> pp f "@[<hov2>!poly!@ %a@]" (simple_expr ctxt) e
730-
| Pexp_poly (e, Some ct) ->
731-
pp f "@[<hov2>(!poly!@ %a@ : %a)@]" (simple_expr ctxt) e (core_type ctxt)
732-
ct
733718
| Pexp_open (ovf, lid, e) ->
734719
pp f "@[<2>let open%s %a in@;%a@]" (override ovf) longident_loc lid
735720
(expression ctxt) e

‎compiler/ml/printast.ml

-15
Original file line numberDiff line numberDiff line change
@@ -318,13 +318,6 @@ and expression i ppf x =
318318
| Pexp_send (e, s) ->
319319
line i ppf "Pexp_send \"%s\"\n" s.txt;
320320
expression i ppf e
321-
| Pexp_new li -> line i ppf "Pexp_new %a\n" fmt_longident_loc li
322-
| Pexp_setinstvar (s, e) ->
323-
line i ppf "Pexp_setinstvar %a\n" fmt_string_loc s;
324-
expression i ppf e
325-
| Pexp_override l ->
326-
line i ppf "Pexp_override\n";
327-
list i string_x_expression ppf l
328321
| Pexp_letmodule (s, me, e) ->
329322
line i ppf "Pexp_letmodule %a\n" fmt_string_loc s;
330323
module_expr i ppf me;
@@ -339,10 +332,6 @@ and expression i ppf x =
339332
| Pexp_lazy e ->
340333
line i ppf "Pexp_lazy\n";
341334
expression i ppf e
342-
| Pexp_poly (e, cto) ->
343-
line i ppf "Pexp_poly\n";
344-
expression i ppf e;
345-
option i core_type ppf cto
346335
| Pexp_newtype (s, e) ->
347336
line i ppf "Pexp_newtype \"%s\"\n" s.txt;
348337
expression i ppf e
@@ -666,10 +655,6 @@ and value_binding i ppf x =
666655
pattern (i + 1) ppf x.pvb_pat;
667656
expression (i + 1) ppf x.pvb_expr
668657

669-
and string_x_expression i ppf (s, e) =
670-
line i ppf "<override> %a\n" fmt_string_loc s;
671-
expression (i + 1) ppf e
672-
673658
and longident_x_expression i ppf (li, e, opt) =
674659
line i ppf "%a%s\n" fmt_longident_loc li (if opt then "?" else "");
675660
expression (i + 1) ppf e

‎compiler/ml/printtyped.ml

-6
Original file line numberDiff line numberDiff line change
@@ -259,10 +259,6 @@ and expression_extra i ppf x attrs =
259259
| Texp_open (ovf, m, _, _) ->
260260
line i ppf "Texp_open %a \"%a\"\n" fmt_override_flag ovf fmt_path m;
261261
attributes i ppf attrs
262-
| Texp_poly cto ->
263-
line i ppf "Texp_poly\n";
264-
attributes i ppf attrs;
265-
option i core_type ppf cto
266262
| Texp_newtype s ->
267263
line i ppf "Texp_newtype \"%s\"\n" s;
268264
attributes i ppf attrs
@@ -279,7 +275,6 @@ and expression i ppf x =
279275
in
280276
match x.exp_desc with
281277
| Texp_ident (li, _, _) -> line i ppf "Texp_ident %a\n" fmt_path li
282-
| Texp_instvar () -> assert false
283278
| Texp_constant c -> line i ppf "Texp_constant %a\n" fmt_constant c
284279
| Texp_let (rf, l, e) ->
285280
line i ppf "Texp_let %a\n" fmt_rec_flag rf;
@@ -361,7 +356,6 @@ and expression i ppf x =
361356
line i ppf "Texp_send \"%s\"\n" s;
362357
expression i ppf e;
363358
option i expression ppf eo
364-
| Texp_new _ | Texp_setinstvar _ | Texp_override _ -> ()
365359
| Texp_letmodule (s, _, me, e) ->
366360
line i ppf "Texp_letmodule \"%a\"\n" fmt_ident s;
367361
module_expr i ppf me;

0 commit comments

Comments
 (0)