Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exponential notation syntax #7105

Closed

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Oct 17, 2024

Fix #6986

cristianoc and others added 16 commits October 19, 2024 09:35
Fixes rescript-lang#7103

The Jsx.element type has moved from Pervasives.
* Fix gentype error message (.rei -> .resi)

* Fix deprecation warnings in gentype example

* Gentype example: String.t -> string (preparation for Core)
* Capitalize runtime filenames

* CHANGELOG
* Add Core sources

* Remove @rescript/core from playground bundle

* Move ocaml compat modules into tests

* Remove Core__ prefix from file names

* Remove Core__ prefix from module names

* make artifacts

* __ -> _

* Fix tests

* Add Array.unsafe_get for compatibility

* CHANGELOG

* Improve cleaning in runtime build script

* Js_exn -> Exn

* Move Core Global into Pervasives
* refactor: extract fun from process_cmt_file

* refactor: read the .cmt earlier

* feat: handle paths via source_file instead of cmt_file

* add project root to default config

* refactor: extract funs to remove duplication

* fix: consider file seperators

* fix: please static checker

* chore: update changelog

* make find source file return only absolute paths

* refactor: cleanup get_output_file and get_output_file_relative
* Build mocha tests as esmodule / .mjs

* CHANGELOG
* Add Core tests

* No open RescriptCore

* Fix imports

* Build Core tests

* Fix test

* Run Core tests in CI

* CHANGELOG
cristianoc and others added 20 commits November 10, 2024 14:34
Fixes rescript-lang#7142

- x ? y : false --> x && y
- x ? false : y --> !x && y
- push negation inside when it leads to simplification
…escript-lang#7000)

* Dune: explicitly set package to "rescript" before adding more packages

* Add package "analysis" from rescript-vscode repo

* Analysis: remove vendored libs that are already in the compiler repo

* Add Tast_iterator module from rescript-vscode repo

* Remove class stuff from Tast_iterator

* Format Tast_iterator

* Fix DeadValue.ml

* No more Config.uncurried

* Analysis: use default print width instead of taking it from syntax cli

* Make pexp_attributes mutable

* Add package "tools" from rescript-vscode repo

* Format OCaml code

* Mark Res_multi_printer.default_print_width as live

* Format

* Do not check in tools/analysis test artifacts

* Add rescript-editor-analysis and rescript-tools to rescript npm package

* Fix path for analysis/tools binaries in test scripts

* Run analysis tests in CI

* analysis: get rid of PervasivesU

* Nullable is now @unboxed

* More pervasives

* Analysis tests: use rescript from this repo and adapt

* Output changes that are ok

* Tools tests: use rescript from this repo

* commit OK changes to analysis output

* commit more OK changes to test output

* get CodeLens to a good enough state

* fix jsx prop completion broken by first class regexp literal support

* use predef paths so weird type lookups do not happen

* commit OK change

* commit OK output

* Fix gitignore

* commit OK output (JSON type changes)

* Do not run analysis tests on Windows

* Add opam exec

* print module name instead of full file name in debug statement

* dont use deprecated functions

* update generic jsx transform test

* update incremental typechecking test

* Fix uppercase exotic idents

* Don't run analysis tests on Linux ARM

* Move tools and analysis tests to tests folder

* CHANGELOG

* Add rescript-tools cli wrapper script

* Remove obsolete Makefile

* Ship RescriptTools module with the rescript npm package

---------

Co-authored-by: Gabriel Nordeborn <gabbe.nord@gmail.com>
* Fix `arguments` and `eval` mangling

Fixed rescript-lang#7162

* add changelog
* Use JSON.t in decodeFromJson

* Add additional signature information to doc json

* Update tests

* Format docgen code

* Revert removal of unwrap_uppercase_exotic

* Update tests

* Update runtime/RescriptTools_Docgen.res

Co-authored-by: Christoph Knittel <christoph@knittel.cc>

* Fix typo in signature

* Fix more typos

---------

Co-authored-by: Christoph Knittel <christoph@knittel.cc>
@shulhi shulhi marked this pull request as ready for review November 23, 2024 12:10
@shulhi shulhi requested review from cknitt, zth and tsnobip November 23, 2024 12:10
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Could you add a CHANGELOG entry (under alpha.6)?

@cknitt
Copy link
Member

cknitt commented Nov 24, 2024

Changes look weird now, showing lots of unrelated stuff from previous PRs.
Have you rebased to latest master?

@shulhi
Copy link
Member Author

shulhi commented Nov 25, 2024

Changes look weird now, showing lots of unrelated stuff from previous PRs. Have you rebased to latest master?

Let me take a look, this is strange.

@shulhi shulhi closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax: E notation check is missing
8 participants