Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further simplification of untagged variant output #7142

Closed
cknitt opened this issue Nov 1, 2024 · 1 comment · Fixed by #7151
Closed

Further simplification of untagged variant output #7142

cknitt opened this issue Nov 1, 2024 · 1 comment · Fixed by #7151

Comments

@cknitt
Copy link
Member

cknitt commented Nov 1, 2024

Followup to #7141.

https://github.com/rescript-lang/rescript-compiler/blob/43d2bbf33fd0d657591aeea719b35a1c316ed77b/tests/tests/src/core/Core_NullableTests.mjs#L10

Could be simplified to tNull === null.

https://github.com/rescript-lang/rescript-compiler/blob/43d2bbf33fd0d657591aeea719b35a1c316ed77b/tests/tests/src/core/Core_NullableTests.mjs#L21

Could be simplified to tUndefined === undefined.

https://github.com/rescript-lang/rescript-compiler/blob/43d2bbf33fd0d657591aeea719b35a1c316ed77b/tests/tests/src/core/Core_NullableTests.mjs#L32

Could be simplified to tValue === "hello".
@cknitt cknitt mentioned this issue Nov 1, 2024
Merged
@cristianoc
Copy link
Collaborator

And this:
#7135 (review)

cristianoc added a commit that referenced this issue Nov 7, 2024
@cristianoc
More boolean simplifications in generated code.
4975e36 
#7142
@cristianoc cristianoc mentioned this issue Nov 8, 2024
Merged
cristianoc added a commit that referenced this issue Nov 8, 2024
@cristianoc
More boolean simplifications in generated code.
25680ed 
#7142
cristianoc added a commit that referenced this issue Nov 8, 2024
@cristianoc
Simplify conditionals.
c9c49f0 
Fixes #7142

- x ? y : false --> x && y
- x ? false : y --> !x && y
- push negation inside when it leads to simplification
@cristianoc cristianoc mentioned this issue Nov 8, 2024
Merged
cristianoc added a commit that referenced this issue Nov 10, 2024
@cristianoc
Simplify conditionals.
912b428 
Fixes #7142

- x ? y : false --> x && y
- x ? false : y --> !x && y
- push negation inside when it leads to simplification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify conditionals codegen + add missing side effects checks. rescript-lang/rescript
2 participants
@cknitt @cristianoc